Why stopping supporting 3.7 3.8 when we can just make life harder for ourselves?

Author: smoia

phys2bids/tests/test_bids.py

@@ -1,6 +1,6 @@
 import os
+import sys
 from csv import reader
-from importlib import resources
 
 import pytest
 import yaml
@@ -34,14 +34,26 @@ def test_bidsify_units():
 @pytest.mark.parametrize("test_sub", ["SBJ01", "sub-006", "006"])
 @pytest.mark.parametrize("test_ses", ["", "S05", "ses-42", "42"])
 def test_use_heuristic(tmpdir, test_sub, test_ses):
-    ref = resources.files("phys2bids") / "heuristics"
-    with resources.as_file(ref) as test_heur_path:
-        test_heur_file = "heur_test_acq.py"
+    test_heur_file = "heur_test_acq.py"
+    test_input_file = "Test_belt_pulse_samefreq.acq"
+
+    if sys.version_info >= (3, 9):
+        from importlib import resources
+
+        ref = resources.files("phys2bids") / "heuristics"
+        with resources.as_file(ref) as test_heur_path:
+            test_full_heur_path = os.path.join(test_heur_path, test_heur_file)
+        ref = resources.files("phys2bids") / "tests/data"
+        with resources.as_file(ref) as test_input_path:
+            test_full_input_path = os.path.join(test_input_path, test_input_file)
+    else:
+        from pkg_resources import resource_filename
+
+        test_heur_path = resource_filename("phys2bids", "heuristics")
         test_full_heur_path = os.path.join(test_heur_path, test_heur_file)
-    ref = resources.files("phys2bids") / "tests/data"
-    with resources.as_file(ref) as test_input_path:
-        test_input_file = "Test_belt_pulse_samefreq.acq"
+        test_input_path = resource_filename("phys2bids", "tests/data")
         test_full_input_path = os.path.join(test_input_path, test_input_file)
+
     test_outdir = tmpdir
     test_record_label = "test"
 

phys2bids/tests/test_integration.py

@@ -4,7 +4,7 @@
 import re
 import shutil
 import subprocess
-from importlib import resources
+import sys
 from os import remove
 from os.path import isfile, join, split
 
@@ -109,8 +109,17 @@ def test_integration_heuristic(skip_integration, multifreq_lab_file):
     test_ntp = 30
     test_tr = 1.2
     test_thr = 0.735
-    ref = resources.files("phys2bids") / "heuristics"
-    with resources.as_file(ref) as heur_path:
+
+    if sys.version_info >= (3, 9):
+        from importlib import resources
+
+        ref = resources.files("phys2bids") / "heuristics"
+        with resources.as_file(ref) as heur_path:
+            test_heur = join(heur_path, "heur_test_multifreq.py")
+    else:
+        from pkg_resources import resource_filename
+
+        heur_path = resource_filename("phys2bids", "heuristics")
         test_heur = join(heur_path, "heur_test_multifreq.py")
 
     # Move into folder