-
Notifications
You must be signed in to change notification settings - Fork 19
Complete overwrite of RETROICOR computation to allow multiple physiological modalities and their interactions #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smoia
wants to merge
12
commits into
physiopy:master
Choose a base branch
from
smoia:fix/retroicor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hysiological data (like most other metrics) and vectorised for efficiency.
…ta types entry and for interactions!
for more information, see https://pre-commit.ci
Member
Author
|
Also @alaurasparsi this is of interest for you! |
Co-authored-by: Stefano Moia <[email protected]> Co-authored-by: alaurasparsi <[email protected]>
Co-authored-by: Stefano Moia <[email protected]> Co-authored-by: alaurasparsi <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 53.85% 44.55% -9.31%
==========================================
Files 8 9 +1
Lines 596 606 +10
==========================================
- Hits 321 270 -51
- Misses 275 336 +61
🚀 New features to boost your workflow:
|
smoia
commented
Aug 8, 2025
| Retroicor regressors are organised in a dictionary of two dictionaries, one for | ||
| retroicor regressors and one for phases. These dictionaries have one entry per | ||
| slice. | ||
| All entries are lists, always organised: cardiac regressors first, then |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes more sense to invert order to follow input order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Internal
Changes affect the internal API. It doesn't increase the version, but produces a changelog
Minormod-breaking
For development only, this PR increments the minor version (0.+1.0) but breaks compatibility
Testing
This is for testing features, writing tests or producing testing code.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Turns out (or so I think) we were computing RETROICOR in a horrible (if not wrong) way due to a few oversights from reviewers (me included) and code authors.
In fixing the issues, I decided to just rewrite everything to improve computation and allow for interactive effects to be computed.
Proposed Changes
Phases:
Consequently, RETROICOR:
Tagging @CesarCaballeroGaudes @afni-dglen @mrikasper because of your expertise with RETROICOR and its implementation in code. Tagging @m-miedema and @me-pic for your expertise on phys2denoise.
Change Type
bugfix(+0.0.1)minor(+0.1.0)major(+1.0.0)refactoring(no version update)test(no version update)infrastructure(no version update)documentation(no version update)otherChecklist before review