Skip to content

Commit 5e5e538

Browse files
authored
Merge pull request #27 from physiopy/testing
Testing reviewer checklist actions
2 parents 40e92cc + d3b2ab5 commit 5e5e538

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

.github/workflows/main-reviewer.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,29 +25,20 @@ jobs:
2525
SANITIZED_REVIEWERS="$SANITIZED_REVIEWERS $(sanitize "$r")"
2626
done
2727
NEW_REVIEWER=$(jq -r '.requested_reviewer.login' < $GITHUB_EVENT_PATH)
28-
ACTOR=$(jq -r '.sender.login' < $GITHUB_EVENT_PATH)
2928
SANITIZED_NEW_REVIEWER=$(sanitize "$NEW_REVIEWER")
30-
SANITIZED_ACTOR=$(sanitize "$ACTOR")
3129
echo "REVIEWERS=$(echo "$SANITIZED_REVIEWERS" | xargs)" >> $GITHUB_ENV
3230
echo "NEW_REVIEWER=$SANITIZED_NEW_REVIEWER" >> $GITHUB_ENV
33-
echo "ACTOR=$SANITIZED_ACTOR" >> $GITHUB_ENV
3431
3532
- name: Determine checklist type
3633
id: checklist_type
3734
run: |
38-
# Only act if the user requested themselves
39-
if [ "$ACTOR" != "$NEW_REVIEWER" ]; then
40-
echo "SKIP=true" >> $GITHUB_ENV
41-
exit 0
42-
fi
4335
COUNT=$(echo "$REVIEWERS" | grep -c .)
4436
if [ "$COUNT" -eq "1" ]; then
4537
echo "TEMPLATE=main_rev_checklist.md" >> $GITHUB_ENV
46-
echo "SKIP=false" >> $GITHUB_ENV
4738
else
4839
echo "TEMPLATE=rev_checklist.md" >> $GITHUB_ENV
49-
echo "SKIP=false" >> $GITHUB_ENV
5040
fi
41+
echo "SKIP=false" >> $GITHUB_ENV
5142
5243
- name: Prepare checklist
5344
if: env.SKIP == 'false'

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ This workflow automatically assigns labels to a PR if the PR edits a specific fi
3333
### 4 - welcome bot app, defined in [config.yml](https://github.com/physiopy/physiopy-test-workflows/blob/master/.github/config.yml)
3434
This bot automatically posts welcome and thank you messages when a contributor posts their first issue, first PR, and merges first PR. This is a nice way to welcome and thank new contributors, but also acts as an opportunity to direct them towards the relevant contributor guidelines, as needed.
3535

36-
### 5 - main reviewer checklist (desc to come)
36+
### 5 - reviewer checklists on a PR (description to come once workflow finalised)
3737

3838
Example:
3939

0 commit comments

Comments
 (0)