Skip to content

Testing reviewer checklist actions #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

Testing reviewer checklist actions #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f685ec3
Revise reviewer checklist section title
RayStick Sep 8, 2025
05567c4
Merge pull request #28 from physiopy/master
RayStick Sep 8, 2025
d3b2ab5
remove the need for self-assign
RayStick Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .github/workflows/main-reviewer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,29 +25,20 @@ jobs:
SANITIZED_REVIEWERS="$SANITIZED_REVIEWERS $(sanitize "$r")"
done
NEW_REVIEWER=$(jq -r '.requested_reviewer.login' < $GITHUB_EVENT_PATH)
ACTOR=$(jq -r '.sender.login' < $GITHUB_EVENT_PATH)
SANITIZED_NEW_REVIEWER=$(sanitize "$NEW_REVIEWER")
SANITIZED_ACTOR=$(sanitize "$ACTOR")
echo "REVIEWERS=$(echo "$SANITIZED_REVIEWERS" | xargs)" >> $GITHUB_ENV
echo "NEW_REVIEWER=$SANITIZED_NEW_REVIEWER" >> $GITHUB_ENV
echo "ACTOR=$SANITIZED_ACTOR" >> $GITHUB_ENV

- name: Determine checklist type
id: checklist_type
run: |
# Only act if the user requested themselves
if [ "$ACTOR" != "$NEW_REVIEWER" ]; then
echo "SKIP=true" >> $GITHUB_ENV
exit 0
fi
COUNT=$(echo "$REVIEWERS" | grep -c .)
if [ "$COUNT" -eq "1" ]; then
echo "TEMPLATE=main_rev_checklist.md" >> $GITHUB_ENV
echo "SKIP=false" >> $GITHUB_ENV
else
echo "TEMPLATE=rev_checklist.md" >> $GITHUB_ENV
echo "SKIP=false" >> $GITHUB_ENV
fi
echo "SKIP=false" >> $GITHUB_ENV

- name: Prepare checklist
if: env.SKIP == 'false'
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ This workflow automatically assigns labels to a PR if the PR edits a specific fi
### 4 - welcome bot app, defined in [config.yml](https://github.com/physiopy/physiopy-test-workflows/blob/master/.github/config.yml)
This bot automatically posts welcome and thank you messages when a contributor posts their first issue, first PR, and merges first PR. This is a nice way to welcome and thank new contributors, but also acts as an opportunity to direct them towards the relevant contributor guidelines, as needed.

### 5 - main reviewer checklist (desc to come)
### 5 - reviewer checklists on a PR (description to come once workflow finalised)

Example:

Expand Down