Skip to content

Updating Gravity after restoring a v5 Teleport into a v6 instance crashes FTL

Open

Description

Versions

Core
Version is 9564a6e (Latest: null)
Branch is development-v6
Hash is 9564a6e9 (Latest: 4972cc6f)
Web
Version is a6807d1 (Latest: null)
Branch is development-v6
Hash is a6807d1a (Latest: 046b5629)
FTL
Version is vDev-0c36f47 (Latest: null)
Branch is development-v6
Hash is 0c36f47 (Latest: 0c36f47)

Platform

  • OS and version: Armbian 24.8.0-trunk.523 bookworm
  • Platform: Docker @ BananaPi

Expected behavior

  1. Updating Gravity after importing config should succeed
  2. FTL should restart if crashed

Actual behavior / bug

  1. Updating Gravity causes FTL to crash
  2. Once crashed, FTL doesn't restarts automatically, stopping all DNS resolution

Steps to reproduce

Steps to reproduce the behavior:

  1. Create a fresh installation of Pihole on docker
  2. Login to Dashboard
  3. Browse to Teleport
  4. Import a Teleport backup. Import is successful
  5. Browse to Update Gravity. Start update
  6. See error below

pihole | 2024-08-17 12:58:18.204 EDT [237/T293] INFO: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
pihole | 2024-08-17 12:58:18.204 EDT [237/T293] INFO: ----------------------------> FTL crashed! <----------------------------
pihole | 2024-08-17 12:58:18.204 EDT [237/T293] INFO: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
pihole | 2024-08-17 12:58:18.205 EDT [237/T293] INFO: Please report a bug at https://github.com/pi-hole/FTL/issues
pihole | 2024-08-17 12:58:18.205 EDT [237/T293] INFO: and include in your report already the following details:
pihole | 2024-08-17 12:58:18.205 EDT [237/T293] INFO: FTL has been running for 101 seconds
pihole | 2024-08-17 12:58:18.206 EDT [237/T293] INFO: FTL branch: development-v6
pihole | 2024-08-17 12:58:18.206 EDT [237/T293] INFO: FTL version: vDev-0c36f47
pihole | 2024-08-17 12:58:18.206 EDT [237/T293] INFO: FTL commit: 0c36f47
pihole | 2024-08-17 12:58:18.206 EDT [237/T293] INFO: FTL date: 2024-08-14 06:07:59 +0200
pihole | 2024-08-17 12:58:18.206 EDT [237/T293] INFO: FTL user: started as pihole, ended as pihole
pihole | 2024-08-17 12:58:18.207 EDT [237/T293] INFO: Compiled for linux/arm/v7 (compiled on CI) using cc (Alpine 13.2.1_git20240309) 13.2.1 20240309
pihole | 2024-08-17 12:58:18.207 EDT [237/T293] INFO: Process details: MID: 237
pihole | 2024-08-17 12:58:18.207 EDT [237/T293] INFO: PID: 237
pihole | 2024-08-17 12:58:18.207 EDT [237/T293] INFO: TID: 293
pihole | 2024-08-17 12:58:18.207 EDT [237/T293] INFO: Name: housekeeper
pihole | 2024-08-17 12:58:18.208 EDT [237/T293] INFO: Received signal: Segmentation fault
pihole | 2024-08-17 12:58:18.208 EDT [237/T293] INFO: at address: 0x69647508
pihole | 2024-08-17 12:58:18.208 EDT [237/T293] INFO: with code: SEGV_MAPERR (Address not mapped to object)
pihole | 2024-08-17 12:58:18.208 EDT [237/T293] INFO: !!! INFO: pihole-FTL has not been compiled with glibc/backtrace support, not generating one !!!
pihole | 2024-08-17 12:58:18.208 EDT [237/T293] INFO: ------ Listing content of directory /dev/shm ------
pihole | 2024-08-17 12:58:18.208 EDT [237/T293] INFO: File Mode User:Group Size Filename
pihole | 2024-08-17 12:58:18.209 EDT [237/T293] INFO: rwxrwxrwx root:root 280 .
pihole | 2024-08-17 12:58:18.209 EDT [237/T293] INFO: rwxr-xr-x root:root 320 ..
pihole | 2024-08-17 12:58:18.210 EDT [237/T293] INFO: rw------- pihole:pihole 56 FTL-lock
pihole | 2024-08-17 12:58:18.211 EDT [237/T293] INFO: rw------- pihole:pihole 292 FTL-counters
pihole | 2024-08-17 12:58:18.211 EDT [237/T293] INFO: rw------- pihole:pihole 16 FTL-settings
pihole | 2024-08-17 12:58:18.212 EDT [237/T293] INFO: rw------- pihole:pihole 82K FTL-strings
pihole | 2024-08-17 12:58:18.212 EDT [237/T293] INFO: rw------- pihole:pihole 4K FTL-domains
pihole | 2024-08-17 12:58:18.213 EDT [237/T293] INFO: rw------- pihole:pihole 168K FTL-clients
pihole | 2024-08-17 12:58:18.214 EDT [237/T293] INFO: rw------- pihole:pihole 12K FTL-upstreams
pihole | 2024-08-17 12:58:18.214 EDT [237/T293] INFO: rw------- pihole:pihole 295K FTL-queries
pihole | 2024-08-17 12:58:18.215 EDT [237/T293] INFO: rw------- pihole:pihole 8K FTL-overTime
pihole | 2024-08-17 12:58:18.216 EDT [237/T293] INFO: rw------- pihole:pihole 20K FTL-dns-cache
pihole | 2024-08-17 12:58:18.216 EDT [237/T293] INFO: rw------- pihole:pihole 4K FTL-per-client-regex
pihole | 2024-08-17 12:58:18.217 EDT [237/T293] INFO: rw------- pihole:pihole 560K FTL-fifo-log
pihole | 2024-08-17 12:58:18.217 EDT [237/T293] INFO: ---------------------------------------------------
pihole | 2024-08-17 12:58:18.217 EDT [237/T293] INFO: Please also include some lines from above the !!!!!!!!! header.
pihole | 2024-08-17 12:58:18.218 EDT [237/T293] INFO: Thank you for helping us to improve our FTL engine!
pihole | 2024-08-17 12:58:18.218 EDT [237/T293] INFO: Waiting for threads to join
pihole | 2024-08-17 12:58:18.218 EDT [237/T293] INFO: Thread database (0) is idle, terminating it.
pihole | 2024-08-17 12:58:18.281 EDT [237/T294] INFO: Terminating resolver thread
pihole | 2024-08-17 12:58:18.312 EDT [237/T295] INFO: Terminating timer thread
pihole | 2024-08-17 12:58:20.218 EDT [237/T293] INFO: Thread housekeeper (1) is still busy, cancelling `it.

Debug Token

Additional context

  1. To everyone contributing to Pihole project, thank you! You rock!
  2. This issue happens when restoring a v5 Teleport backup in a clean v6 instance. Restoring the same v5 Teleport backup in another v5 instance does not cause the described failure (as of today, based on the latest v5 at pihole/pihole:latest)
  3. Before posting this I exercised reproducing the issue multiple times. Failure is consistent
  4. Updating Gravity before import (with only the default list) works fine
  5. After restarting the container, updating Gravity works fine as well (including the imported lists)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions