Skip to content

Commit a1da4c2

Browse files
committed
Restore form spacing and tone down more dark-theme accents
- Bootstrap 5 also removed `.form-group` (row bottom margin) and `.help-block` (muted helper text); both are used across the settings and query-log forms, so restore them. This recovers the vertical spacing that was missing between form rows throughout the interface. - Dark theme: mute the active pagination link and the filled `.card-info` / `.card-primary` card headers (e.g. the query-log "Advanced filtering" box), which used Bootstrap's over-bright `#0d6efd`/`#0dcaf0` on the dark background. The headers are recoloured via AdminLTE 4's `--lte-card-variant-*` variables. - Widen the reverse-DNS servers table's "Enabled" column so its header no longer overflows into the next column. Signed-off-by: DL6ER <dl6er@dl6er.de>
1 parent 0a572ed commit a1da4c2

3 files changed

Lines changed: 33 additions & 1 deletion

File tree

scripts/js/settings-dns.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ function createRevServerTable() {
167167
data: tableRows,
168168
autoWidth: false,
169169
columns: [
170-
{ data: "enabled", width: "54px", className: "revserver-chkbox text-center" },
170+
{ data: "enabled", width: "76px", className: "revserver-chkbox text-center" },
171171
{ data: "network", className: "revserver-network" },
172172
{ data: "ip", className: "revserver-ip" },
173173
{ data: "domain", className: "revserver-domain" },

style/pi-hole.css

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,19 @@
7373
gap: 0.5rem;
7474
}
7575

76+
/* Bootstrap 5 removed `.form-group` (which carried the bottom margin between
77+
form rows) and `.help-block` (muted helper text). The templates still use
78+
both throughout, so restore their spacing/appearance rather than rewrite
79+
every form to `.mb-3`/`.form-text`. */
80+
.form-group {
81+
margin-bottom: 1rem;
82+
}
83+
.help-block {
84+
display: block;
85+
margin-top: 0.25rem;
86+
color: var(--bs-secondary-color);
87+
}
88+
7689
/* AdminLTE 4 no longer swaps the mini/full logo in the header when the sidebar
7790
is collapsed, so the full "Pi-hole" wordmark stays and wraps in the narrow
7891
header. Show the compact "Ph" mark while collapsed instead. */

style/themes/default-dark.css

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,25 @@ body {
3535
h4 {
3636
color: #3c8dbc;
3737
}
38+
/* Tone down Bootstrap's bright accent fills, which are too saturated on the
39+
dark background (the active page link and the filled coloured card headers
40+
such as the query-log "Advanced filtering" box). */
41+
.page-item.active > .page-link {
42+
background-color: #3c8dbc;
43+
border-color: #3c8dbc;
44+
}
45+
.card-info {
46+
--lte-card-variant-bg: #256170;
47+
--lte-card-variant-bg-rgb: 37, 97, 112;
48+
--lte-card-variant-color: #d6eef5;
49+
--lte-card-variant-color-rgb: 214, 238, 245;
50+
}
51+
.card-primary {
52+
--lte-card-variant-bg: #285a7a;
53+
--lte-card-variant-bg-rgb: 40, 90, 122;
54+
--lte-card-variant-color: #d6e5f2;
55+
--lte-card-variant-color-rgb: 214, 229, 242;
56+
}
3857
.callout h4 {
3958
color: inherit;
4059
}

0 commit comments

Comments
 (0)