Merge pull request #155 from holtkamp/use-class-constant

Use class constant

Author: stephangroen

src/Picqer/Financials/Moneybird/Actions/BaseTrait.php

@@ -26,7 +26,7 @@ abstract protected function getEndpoint();
      *
      * @see \Picqer\Financials\Moneybird\Model::collectionFromResult()
      */
-    abstract protected function collectionFromResult($result);
+    abstract protected function collectionFromResult(array $result);
 
     /**
      * Create a new object with the response from the API
@@ -37,6 +37,6 @@ abstract protected function collectionFromResult($result);
      *
      * @see \Picqer\Financials\Moneybird\Model::makeFromResponse()
      */
-    abstract protected function makeFromResponse($response);
+    abstract protected function makeFromResponse(array $response);
 
 }

src/Picqer/Financials/Moneybird/Entities/Contact.php

@@ -12,6 +12,9 @@
 /**
  * Class Contact
  * @package Picqer\Financials\Moneybird
+ *
+ * @property string $id
+ * @property ContactCustomField[] $custom_fields
  */
 class Contact extends Model
 {
@@ -76,7 +79,7 @@ class Contact extends Model
      */
     protected $multipleNestedEntities = [
         'custom_fields' => [
-            'entity' => 'ContactCustomField',
+            'entity' => ContactCustomField::class,
             'type' => self::NESTING_TYPE_NESTED_OBJECTS,
         ],
     ];

src/Picqer/Financials/Moneybird/Entities/ContactCustomField.php

@@ -5,6 +5,10 @@
 /**
  * Class ContactCustomField
  * @package Picqer\Financials\Moneybird\Entities
+ *
+ * @property string $id
+ * @property string $name
+ * @property string $value
  */
 class ContactCustomField extends Model {
 

src/Picqer/Financials/Moneybird/Entities/Estimate.php

@@ -81,15 +81,15 @@ class Estimate extends Model
      */
     protected $multipleNestedEntities = [
         'custom_fields' => [
-            'entity' => 'SalesInvoiceCustomField',
+            'entity' => SalesInvoiceCustomField::class,
             'type' => self::NESTING_TYPE_ARRAY_OF_OBJECTS,
         ],
         'details' => [
-            'entity' => 'SalesInvoiceDetail',
+            'entity' => SalesInvoiceDetail::class,
             'type' => self::NESTING_TYPE_ARRAY_OF_OBJECTS,
         ],
         'notes' => [
-            'entity' => 'Note',
+            'entity' => Note::class,
             'type' => self::NESTING_TYPE_ARRAY_OF_OBJECTS,
         ],
     ];

src/Picqer/Financials/Moneybird/Entities/FinancialMutation.php

@@ -78,7 +78,7 @@ class FinancialMutation extends Model {
      */
     protected $multipleNestedEntities = [
         'ledger_account_bookings' => [
-            'entity' => 'LedgerAccountBooking',
+            'entity' => LedgerAccountBooking::class,
             'type' => self::NESTING_TYPE_ARRAY_OF_OBJECTS,
         ],
     ];

src/Picqer/Financials/Moneybird/Entities/FinancialStatement.php

@@ -40,7 +40,7 @@ class FinancialStatement extends Model {
      */
     protected $multipleNestedEntities = [
         'financial_mutations' => [
-            'entity' => 'FinancialMutation',
+            'entity' => FinancialMutation::class,
             'type' => self::NESTING_TYPE_ARRAY_OF_OBJECTS,
         ],
     ];

src/Picqer/Financials/Moneybird/Entities/GeneralJournalDocument.php

@@ -43,7 +43,7 @@ class GeneralJournalDocument extends Model {
      */
     protected $multipleNestedEntities = [
         'general_journal_document_entries' => [
-            'entity' => 'GeneralJournalDocumentEntry',
+            'entity' => GeneralJournalDocumentEntry::class,
             'type' => self::NESTING_TYPE_ARRAY_OF_OBJECTS,
         ],
     ];

src/Picqer/Financials/Moneybird/Entities/Note.php

@@ -5,6 +5,11 @@
 /**
  * Class Note
  * @package Picqer\Financials\Moneybird\Entities
+ *
+ * @property string $id
+ * @property string $note
+ * @property boolean $todo
+ * @property string $assignee_id
  */
 class Note extends Model {
     /**

src/Picqer/Financials/Moneybird/Entities/PurchaseInvoice.php

@@ -62,15 +62,15 @@ class PurchaseInvoice extends Model
      * @var array
      */
     protected $singleNestedEntities = [
-        'contact' => 'Contact'
+        'contact' => Contact::class,
     ];
 
     /**
      * @var array
      */
     protected $multipleNestedEntities = [
         'details' => [
-            'entity' => 'PurchaseInvoiceDetail',
+            'entity' => PurchaseInvoiceDetail::class,
             'type' => self::NESTING_TYPE_ARRAY_OF_OBJECTS,
         ],
     ];

src/Picqer/Financials/Moneybird/Entities/Receipt.php

@@ -60,7 +60,7 @@ class Receipt extends Model {
      */
     protected $multipleNestedEntities = [
         'details' => [
-            'entity' => 'ReceiptDetail',
+            'entity' => ReceiptDetail::class,
             'type' => self::NESTING_TYPE_ARRAY_OF_OBJECTS,
         ],
     ];