Update to phpunit 8.5

Author: casperbakker

composer.json

@@ -20,7 +20,7 @@
         "php": ">=7.2.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^5.3"
+        "phpunit/phpunit": "^8.5"
     },
     "autoload": {
         "psr-4": {

phpunit.xml

@@ -8,7 +8,6 @@
          processIsolation="false"
          stopOnError="false"
          stopOnFailure="false"
-         syntaxCheck="true"
          verbose="true"
 >
     <testsuites>

tests/BarcodeTest.php

@@ -1,108 +1,85 @@
 <?php
 
-class BarcodeTest extends PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class BarcodeTest extends TestCase
 {
-    /**
-     * @test
-     */
-    public function png_barcode_generator_can_generate_code_128_barcode()
+    public function test_png_barcode_generator_can_generate_code_128_barcode()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorPNG();
         $generated = $generator->getBarcode('081231723897', $generator::TYPE_CODE_128);
 
         $this->assertEquals('PNG', substr($generated, 1, 3));
     }
 
-    /**
-     * @test
-     */
-    public function svg_barcode_generator_can_generate_ean_13_barcode()
+    public function test_svg_barcode_generator_can_generate_ean_13_barcode()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $generated = $generator->getBarcode('081231723897', $generator::TYPE_EAN_13);
 
         $this->assertStringEqualsFile('tests/verified-files/081231723897-ean13.svg', $generated);
     }
 
-    /**
-     * @test
-     */
-    public function html_barcode_generator_can_generate_code_128_barcode()
+    public function test_html_barcode_generator_can_generate_code_128_barcode()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorHTML();
         $generated = $generator->getBarcode('081231723897', $generator::TYPE_CODE_128);
 
         $this->assertStringEqualsFile('tests/verified-files/081231723897-code128.html', $generated);
     }
 
-    /**
-     * @test
-     */
-    public function jpg_barcode_generator_can_generate_code_128_barcode()
+    public function test_jpg_barcode_generator_can_generate_code_128_barcode()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorJPG();
-        $generator->getBarcode('081231723897', $generator::TYPE_CODE_128);
+        $result = $generator->getBarcode('081231723897', $generator::TYPE_CODE_128);
+
+        $this->assertGreaterThan(1000, strlen($result));
     }
 
-    /**
-     * @test
-     * @expectedException \Picqer\Barcode\Exceptions\InvalidCharacterException
-     */
-    public function ean13_generator_throws_exception_if_invalid_chars_are_used()
+    public function test_ean13_generator_throws_exception_if_invalid_chars_are_used()
     {
+        $this->expectException(Picqer\Barcode\Exceptions\InvalidCharacterException::class);
+
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $generator->getBarcode('A123', $generator::TYPE_EAN_13);
     }
 
-    /**
-     * @test
-     */
-    public function ean13_generator_accepting_13_chars()
+    public function test_ean13_generator_accepting_13_chars()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $generated = $generator->getBarcode('0049000004632', $generator::TYPE_EAN_13);
 
         $this->assertStringEqualsFile('tests/verified-files/0049000004632-ean13.svg', $generated);
     }
 
-    /**
-     * @test
-     */
-    public function ean13_generator_accepting_12_chars_and_generates_13th_check_digit()
+    public function test_ean13_generator_accepting_12_chars_and_generates_13th_check_digit()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $generated = $generator->getBarcode('004900000463', $generator::TYPE_EAN_13);
 
         $this->assertStringEqualsFile('tests/verified-files/0049000004632-ean13.svg', $generated);
     }
 
-    /**
-     * @test
-     */
-    public function ean13_generator_accepting_11_chars_and_generates_13th_check_digit_and_adds_leading_zero()
+    public function test_ean13_generator_accepting_11_chars_and_generates_13th_check_digit_and_adds_leading_zero()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $generated = $generator->getBarcode('04900000463', $generator::TYPE_EAN_13);
 
         $this->assertStringEqualsFile('tests/verified-files/0049000004632-ean13.svg', $generated);
     }
 
-    /**
-     * @test
-     * @expectedException \Picqer\Barcode\Exceptions\InvalidCheckDigitException
-     */
-    public function ean13_generator_throws_exception_when_wrong_check_digit_is_given()
+    public function test_ean13_generator_throws_exception_when_wrong_check_digit_is_given()
     {
+        $this->expectException(Picqer\Barcode\Exceptions\InvalidCheckDigitException::class);
+
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $generator->getBarcode('0049000004633', $generator::TYPE_EAN_13);
     }
 
-    /**
-     * @test
-     * @expectedException \Picqer\Barcode\Exceptions\UnknownTypeException
-     */
-    public function generator_throws_unknown_type_exceptions()
+    public function test_generator_throws_unknown_type_exceptions()
     {
+        $this->expectException(Picqer\Barcode\Exceptions\UnknownTypeException::class);
+
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $generator->getBarcode('0049000004633', 'vladimir');
     }