Extra checks for EAN-13 length #1

Author: casperbakker

Readme.md

@@ -1,8 +1,6 @@
-# PHP Barcode Generator
+# PHP Barcode Generator [![Build Status](https://travis-ci.org/picqer/php-barcode-generator.svg?branch=master)](https://travis-ci.org/picqer/php-barcode-generator) [![Total Downloads](https://poser.pugx.org/picqer/php-barcode-generator/downloads)](https://packagist.org/packages/picqer/php-barcode-generator)
 This is an easy to use, non-bloated, framework independent, barcode generator in PHP.
 
-[![Build Status](https://travis-ci.org/picqer/php-barcode-generator.svg?branch=master)](https://travis-ci.org/picqer/php-barcode-generator)
-
 It creates SVG, PNG, JPG and HTML images, from the most used 1D barcode standards.
 
 *The codebase is largely from the [TCPDF barcode generator](https://github.com/tecnickcom/TCPDF) by Nicola Asuni. This code is therefor licensed under LGPLv3. It is still a bit of a mess, bit I will clean it in the future. I do not expect the interface of this class will change during the clean ups.*

generate-verified-files.php

@@ -11,3 +11,6 @@
 
 $generatorHTML = new Picqer\Barcode\BarcodeGeneratorHTML();
 file_put_contents('tests/verified-files/081231723897-code128.html', $generatorHTML->getBarcode('081231723897', $generatorHTML::TYPE_CODE_128));
+
+$generatorSVG = new Picqer\Barcode\BarcodeGeneratorSVG();
+file_put_contents('tests/verified-files/0049000004632-ean13.svg', $generatorSVG->getBarcode('0049000004632', $generatorSVG::TYPE_EAN_13));

tests/BarcodeTest.php

@@ -53,4 +53,48 @@ public function ean13_generator_throws_exception_if_invalid_chars_are_used()
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $generator->getBarcode('A123', $generator::TYPE_EAN_13);
     }
+
+    /**
+     * @test
+     */
+    public function ean13_generator_accepting_13_chars()
+    {
+        $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
+        $generated = $generator->getBarcode('0049000004632', $generator::TYPE_EAN_13);
+
+        $this->assertStringEqualsFile('tests/verified-files/0049000004632-ean13.svg', $generated);
+    }
+
+    /**
+     * @test
+     */
+    public function ean13_generator_accepting_12_chars_and_generates_13th_check_digit()
+    {
+        $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
+        $generated = $generator->getBarcode('004900000463', $generator::TYPE_EAN_13);
+
+        $this->assertStringEqualsFile('tests/verified-files/0049000004632-ean13.svg', $generated);
+    }
+
+    /**
+     * @test
+     */
+    public function ean13_generator_accepting_11_chars_and_generates_13th_check_digit_and_adds_leading_zero()
+    {
+        $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
+        $generated = $generator->getBarcode('04900000463', $generator::TYPE_EAN_13);
+
+        $this->assertStringEqualsFile('tests/verified-files/0049000004632-ean13.svg', $generated);
+    }
+
+
+    /**
+     * @test
+     * @expectedException \Picqer\Barcode\Exceptions\InvalidCheckDigitException
+     */
+    public function ean13_generator_throws_exception_when_wrong_check_digit_is_given()
+    {
+        $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
+        $generator->getBarcode('0049000004633', $generator::TYPE_EAN_13);
+    }
 }