Fix invalid chars in test files filename #94

Author: casperbakker

examples.md

@@ -48,7 +48,7 @@ These are examples of supported barcodes with this library.
 
 ![Barcode 081231723897 as C128](tests/verified-files/C128-081231723897.svg)
 
-![Barcode 1234567890abcABC-283*33 as C128](tests/verified-files/C128-1234567890abcABC-283*33.svg)
+![Barcode 1234567890abcABC-283*33 as C128](tests/verified-files/C128-1234567890abcABC-283-33.svg)
 
 ### C128A
 
@@ -58,15 +58,15 @@ These are examples of supported barcodes with this library.
 
 ![Barcode 081231723897 as C128B](tests/verified-files/C128B-081231723897.svg)
 
-![Barcode 1234567890abcABC-283*33 as C128B](tests/verified-files/C128B-1234567890abcABC-283*33.svg)
+![Barcode 1234567890abcABC-283*33 as C128B](tests/verified-files/C128B-1234567890abcABC-283-33.svg)
 
 ### EAN2
 
 ![Barcode 22 as EAN2](tests/verified-files/EAN2-22.svg)
 
 ### EAN5
 
-![Barcode 1234567890abcABC-283*33 as EAN5](tests/verified-files/EAN5-1234567890abcABC-283*33.svg)
+![Barcode 1234567890abcABC-283*33 as EAN5](tests/verified-files/EAN5-1234567890abcABC-283-33.svg)
 
 ### EAN8
 

generate-examples.php

@@ -1,5 +1,9 @@
 <?php
 
+function getSaveFilename($value) {
+    return preg_replace('/[^a-zA-Z0-9_ \-+]/s', '-', $value);
+}
+
 require('vendor/autoload.php');
 require(__DIR__ . '/tests/VerifiedBarcodeTest.php');
 $verifiedFiles = VerifiedBarcodeTest::$supportedBarcodes;
@@ -12,7 +16,7 @@
 foreach ($verifiedFiles as $verifiedFile) {
     $result[] = '### ' . $verifiedFile['type'];
     foreach ($verifiedFile['barcodes'] as $barcode) {
-        $result[] = sprintf('![Barcode %s as %s](tests/verified-files/%s-%s.svg)', $barcode, $verifiedFile['type'], $verifiedFile['type'], $barcode);
+        $result[] = sprintf('![Barcode %s as %s](tests/verified-files/%s.svg)', $barcode, $verifiedFile['type'], getSaveFilename($verifiedFile['type'] . '-' . $barcode));
     }
 }
 

generate-verified-files.php

@@ -2,6 +2,10 @@
 
 require('vendor/autoload.php');
 
+function getSaveFilename($value) {
+    return preg_replace('/[^a-zA-Z0-9_ \-+]/s', '-', $value);
+}
+
 $generatorSVG = new Picqer\Barcode\BarcodeGeneratorSVG();
 file_put_contents('tests/verified-files/081231723897-ean13.svg', $generatorSVG->getBarcode('081231723897', $generatorSVG::TYPE_EAN_13));
 
@@ -19,6 +23,6 @@
 $generatorSVG = new Picqer\Barcode\BarcodeGeneratorSVG();
 foreach ($verifiedFiles as $verifiedFile) {
     foreach ($verifiedFile['barcodes'] as $barcode) {
-        file_put_contents('tests/verified-files/' . $verifiedFile['type'] . '-' . $barcode . '.svg', $generatorSVG->getBarcode($barcode, $verifiedFile['type']));
+        file_put_contents('tests/verified-files/' . getSaveFilename($verifiedFile['type'] . '-' . $barcode) . '.svg', $generatorSVG->getBarcode($barcode, $verifiedFile['type']));
     }
 }

tests/TypesTest.php

@@ -73,7 +73,7 @@ public function test_generator_can_generate_code_128_barcode()
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $result = $generator->getBarcode('1234567890abcABC-283*33', $generator::TYPE_CODE_128);
 
-        $this->assertStringEqualsFile('tests/verified-files/C128-1234567890abcABC-283*33.svg', $result);
+        $this->assertStringEqualsFile('tests/verified-files/C128-1234567890abcABC-283-33.svg', $result);
     }
 
     public function test_generator_can_generate_code_128_a_barcode()
@@ -89,7 +89,7 @@ public function test_generator_can_generate_code_128_b_barcode()
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
         $result = $generator->getBarcode('1234567890abcABC-283*33', $generator::TYPE_CODE_128_B);
 
-        $this->assertStringEqualsFile('tests/verified-files/C128B-1234567890abcABC-283*33.svg', $result);
+        $this->assertStringEqualsFile('tests/verified-files/C128B-1234567890abcABC-283-33.svg', $result);
     }
 
     public function test_generator_can_generate_ean_2_barcode()

tests/VerifiedBarcodeTest.php

@@ -53,11 +53,15 @@ public function testAllSupportedBarcodeTypes()
                 $result = $generator->getBarcode($barcode, $barcodeTestSet['type']);
 
                 $this->assertStringEqualsFile(
-                    sprintf('tests/verified-files/%s-%s.svg', $barcodeTestSet['type'], $barcode),
+                    sprintf('tests/verified-files/%s.svg', $this->getSaveFilename($barcodeTestSet['type'] . '-' . $barcode)),
                     $result,
                     sprintf('%s x %s dynamic test failed', $barcodeTestSet['type'], $barcode)
                 );
             }
         }
     }
+
+    protected function getSaveFilename($value) {
+        return preg_replace('/[^a-zA-Z0-9_ \-+]/s', '-', $value);
+    }
 }