Merge pull request #160 from Bernhard-Krop/code-39-extended

Fixing a bug in Code 39 Extended (with or without checksum)

Author: casperbakker

src/Types/TypeCode39.php

@@ -70,8 +70,6 @@ public function getBarcodeData(string $code): Barcode
             throw new InvalidLengthException('You should provide a barcode string.');
         }
 
-        $code = strtoupper($code);
-
         if ($this->extended) {
             // extended mode
             $code = $this->encode_code39_ext($code);

tests/TypesTest.php

@@ -7,19 +7,27 @@ class TypesTest extends TestCase
     public function test_generator_can_generate_code_39_barcode()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
-        $result = $generator->getBarcode('1234567890abcABC', $generator::TYPE_CODE_39);
+        $result = $generator->getBarcode('1234567890ABC', $generator::TYPE_CODE_39);
 
-        $this->assertStringEqualsFile('tests/verified-files/C39-1234567890abcABC.svg', $result);
+        $this->assertStringEqualsFile('tests/verified-files/C39-1234567890ABC.svg', $result);
     }
 
     public function test_generator_can_generate_code_39_checksum_barcode()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
-        $result = $generator->getBarcode('1234567890abcABC', $generator::TYPE_CODE_39_CHECKSUM);
+        $result = $generator->getBarcode('1234567890ABC', $generator::TYPE_CODE_39_CHECKSUM);
 
         $this->assertGreaterThan(100, strlen($result));
     }
 
+    public function test_generator_can_generate_code_39_extended_barcode()
+    {
+        $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
+        $result = $generator->getBarcode('1234567890abcABC', $generator::TYPE_CODE_39E);
+
+        $this->assertStringEqualsFile('tests/verified-files/C39E-1234567890abcABC.svg', $result);
+    }
+
     public function test_generator_can_generate_code_39_extended_checksum_barcode()
     {
         $generator = new Picqer\Barcode\BarcodeGeneratorSVG();

tests/VerifiedBarcodeTest.php

@@ -14,8 +14,9 @@
 class VerifiedBarcodeTest extends TestCase
 {
     public static $supportedBarcodes = [
-        ['type' => BarcodeGenerator::TYPE_CODE_39, 'barcodes' => ['1234567890abcABC']],
-        ['type' => BarcodeGenerator::TYPE_CODE_39_CHECKSUM, 'barcodes' => ['1234567890abcABC']],
+        ['type' => BarcodeGenerator::TYPE_CODE_39, 'barcodes' => ['1234567890ABC']],
+        ['type' => BarcodeGenerator::TYPE_CODE_39_CHECKSUM, 'barcodes' => ['1234567890ABC']],
+        ['type' => BarcodeGenerator::TYPE_CODE_39E, 'barcodes' => ['1234567890abcABC']],
         ['type' => BarcodeGenerator::TYPE_CODE_39E_CHECKSUM, 'barcodes' => ['1234567890abcABC']],
         ['type' => BarcodeGenerator::TYPE_CODE_93, 'barcodes' => ['1234567890abcABC']],
         ['type' => BarcodeGenerator::TYPE_STANDARD_2_5, 'barcodes' => ['1234567890']],