Skip to content

Commit da57395

Browse files
author
Callum Smith
committed
Correct math calcuation of bar width
1 parent b23628f commit da57395

File tree

2 files changed

+29
-29
lines changed

2 files changed

+29
-29
lines changed

‎src/BarcodeGeneratorDynamicHTML.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public function getBarcode($barcode, $type, string $foregroundColor = 'black')
2323
$positionHorizontal = 0;
2424
/** @var BarcodeBar $bar */
2525
foreach ($barcodeData->getBars() as $bar) {
26-
$barWidth = $bar->getWidth() / $widthFactor;
26+
$barWidth = $bar->getWidth() * $widthFactor;
2727

2828
if ($bar->isBar() && $barWidth > 0) {
2929
// draw a vertical bar

‎tests/verified-files/081231723897-dynamic-code128.html‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
<div style="font-size:0;position:relative;width:100%;height:100%">
2-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:0%;top:0;">&nbsp;</div>
3-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:3.03%;top:0;">&nbsp;</div>
4-
<div style="background-color:black;width:3.03%;height:100%;position:absolute;left:6.06%;top:0;">&nbsp;</div>
5-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:11.11%;top:0;">&nbsp;</div>
6-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:15.15%;top:0;">&nbsp;</div>
7-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:19.19%;top:0;">&nbsp;</div>
8-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:22.22%;top:0;">&nbsp;</div>
9-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:24.24%;top:0;">&nbsp;</div>
10-
<div style="background-color:black;width:3.03%;height:100%;position:absolute;left:28.28%;top:0;">&nbsp;</div>
11-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:33.33%;top:0;">&nbsp;</div>
12-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:36.36%;top:0;">&nbsp;</div>
13-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:41.41%;top:0;">&nbsp;</div>
14-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:44.44%;top:0;">&nbsp;</div>
15-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:47.47%;top:0;">&nbsp;</div>
16-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:53.53%;top:0;">&nbsp;</div>
17-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:55.55%;top:0;">&nbsp;</div>
18-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:59.59%;top:0;">&nbsp;</div>
19-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:64.64%;top:0;">&nbsp;</div>
20-
<div style="background-color:black;width:4.04%;height:100%;position:absolute;left:66.66%;top:0;">&nbsp;</div>
21-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:71.71%;top:0;">&nbsp;</div>
22-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:73.73%;top:0;">&nbsp;</div>
23-
<div style="background-color:black;width:3.03%;height:100%;position:absolute;left:77.77%;top:0;">&nbsp;</div>
24-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:81.81%;top:0;">&nbsp;</div>
25-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:83.83%;top:0;">&nbsp;</div>
26-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:88.88%;top:0;">&nbsp;</div>
27-
<div style="background-color:black;width:3.03%;height:100%;position:absolute;left:93.93%;top:0;">&nbsp;</div>
28-
<div style="background-color:black;width:1.01%;height:100%;position:absolute;left:97.97%;top:0;">&nbsp;</div>
29-
<div style="background-color:black;width:2.02%;height:100%;position:absolute;left:99.99%;top:0;">&nbsp;</div>
2+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:0%;top:0;">&nbsp;</div>
3+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:2.970297029703%;top:0;">&nbsp;</div>
4+
<div style="background-color:black;width:2.970297029703%;height:100%;position:absolute;left:5.9405940594059%;top:0;">&nbsp;</div>
5+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:10.891089108911%;top:0;">&nbsp;</div>
6+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:14.851485148515%;top:0;">&nbsp;</div>
7+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:18.811881188119%;top:0;">&nbsp;</div>
8+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:21.782178217822%;top:0;">&nbsp;</div>
9+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:23.762376237624%;top:0;">&nbsp;</div>
10+
<div style="background-color:black;width:2.970297029703%;height:100%;position:absolute;left:27.722772277228%;top:0;">&nbsp;</div>
11+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:32.673267326733%;top:0;">&nbsp;</div>
12+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:35.643564356436%;top:0;">&nbsp;</div>
13+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:40.594059405941%;top:0;">&nbsp;</div>
14+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:43.564356435644%;top:0;">&nbsp;</div>
15+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:46.534653465347%;top:0;">&nbsp;</div>
16+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:52.475247524752%;top:0;">&nbsp;</div>
17+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:54.455445544554%;top:0;">&nbsp;</div>
18+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:58.415841584158%;top:0;">&nbsp;</div>
19+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:63.366336633663%;top:0;">&nbsp;</div>
20+
<div style="background-color:black;width:3.960396039604%;height:100%;position:absolute;left:65.346534653465%;top:0;">&nbsp;</div>
21+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:70.29702970297%;top:0;">&nbsp;</div>
22+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:72.277227722772%;top:0;">&nbsp;</div>
23+
<div style="background-color:black;width:2.970297029703%;height:100%;position:absolute;left:76.237623762376%;top:0;">&nbsp;</div>
24+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:80.19801980198%;top:0;">&nbsp;</div>
25+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:82.178217821782%;top:0;">&nbsp;</div>
26+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:87.128712871287%;top:0;">&nbsp;</div>
27+
<div style="background-color:black;width:2.970297029703%;height:100%;position:absolute;left:92.079207920792%;top:0;">&nbsp;</div>
28+
<div style="background-color:black;width:0.99009900990099%;height:100%;position:absolute;left:96.039603960396%;top:0;">&nbsp;</div>
29+
<div style="background-color:black;width:1.980198019802%;height:100%;position:absolute;left:98.019801980198%;top:0;">&nbsp;</div>
3030
</div>

0 commit comments

Comments
 (0)