Merge pull request #60 from picqer/PIC-4157-perf

perf: Moved `array_merge` out of the loop when paginating results

Author: casperbakker

.gitignore

@@ -1,3 +1,5 @@
+.DS_Store
+.idea
 composer.phar
 composer.lock
-vendor/
+vendor/

src/Picqer/Carriers/SendCloud/Query/FindAll.php

@@ -21,11 +21,11 @@ public function all($params = [], ?int $maxPages = 1): array
         while (true) {
             $result = $this->connection()->get($this->url, $params);
 
-            $allRecords = array_merge($allRecords, $this->collectionFromResult($result));
+            $allRecords[] = $this->collectionFromResult($result);
 
             if (! empty($result['next'])) {
                 // Get the querystring params from the next url, so we can retrieve the next page
-                $params = parse_url($result['next'], PHP_URL_QUERY);
+                $params = \parse_url($result['next'], PHP_URL_QUERY);
             } else {
                 // If no next page is found, all records are complete
                 break;
@@ -34,12 +34,12 @@ public function all($params = [], ?int $maxPages = 1): array
             $pages++;
 
             // If max pages is set and reached, also stop the loop
-            if (! is_null($maxPages) && $pages >= $maxPages) {
+            if (null !== $maxPages && $pages >= $maxPages) {
                 break;
             }
         }
 
-        return $allRecords;
+        return \array_merge(...$allRecords);
     }
 
     public function collectionFromResult($result): array