Skip to content

Commit 2e99438

Browse files
authored
Merge pull request #49 from pierotofy/basefix
Fix SH degrees variable mismatch
2 parents 95d5abb + c9c71d4 commit 2e99438

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

model.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ torch::Tensor Model::forward(Camera& cam, int step){
159159

160160
rgbs = torch::clamp_min(rgbs + 0.5f, 0.0f);
161161

162-
163162
if (device == torch::kCPU){
164163
rgb = RasterizeGaussiansCPU::apply(
165164
xys,

vendor/gsplat-cpu/gsplat_cpu.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ torch::Tensor compute_sh_forward_tensor_cpu(
431431
const int numChannels = 3;
432432
unsigned numBases = numShBases(degrees_to_use);
433433

434-
torch::Tensor result = torch::zeros({viewdirs.size(0), numBases}, torch::TensorOptions().dtype(torch::kFloat32).device(viewdirs.device()));
434+
torch::Tensor result = torch::zeros({viewdirs.size(0), numShBases(degree)}, torch::TensorOptions().dtype(torch::kFloat32).device(viewdirs.device()));
435435

436436
result.index_put_({"...", 0}, SH_C0);
437437
if (numBases > 1){
@@ -478,6 +478,6 @@ torch::Tensor compute_sh_forward_tensor_cpu(
478478
}
479479
}
480480
}
481-
481+
482482
return (result.index({"...", None}) * coeffs).sum(-2);
483483
}

0 commit comments

Comments
 (0)