Skip to content

Duplicate function name #11

@johanneskoch94

Description

@johanneskoch94

This function

calcValidPopulation <- function(PopulationPast = "WDI-UN_PopDiv-MI",
PopulationFuture = c("SSPs-UN_PopDiv-MI",
"SDPs-UN_PopDiv-MI",
"SSP2EU-UN_PopDiv-MI"),
TimeFromFindSet = TRUE) {

is redefined here, with the same name:
https://github.com/pik-piam/mrtutorial/blob/552a5a1936274145159065db4b9d3485758f8d78/R/calcValidPopulation.R#L9

This could cause issues down the line I'ld guess ;) In any case, the calcValidPopulation function from this package looks dubious to me. It uses future data for validation, but takes it from calcPopulationFuture, instead of from calcPopulation which has the final scenario data after harmonization. So depending on which function is actually used in our workflows, this should be either refactored (I can do that), or deleted.

I'm not sure who has a good overview ;) @caviddhen @tscheypidi

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions