Skip to content

Commit 62139da

Browse files
author
Nachoo Mangas
committed
ci: using npm-i in matrix, update steps: Configure npm, Install npm modules, Remove npm modules
1 parent 98647e6 commit 62139da

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,10 @@ jobs:
4949
- name: Node.js 0.8
5050
node-version: "0.8"
5151
npm-i: mocha@2.5.3 supertest@1.1.0
52-
npm-rm: nyc
5352

5453
- name: Node.js 0.10
5554
node-version: "0.10"
5655
npm-i: mocha@3.5.3 nyc@10.3.2 supertest@2.0.1
57-
npm-rm: nyc
5856

5957
- name: Node.js 0.12
6058
node-version: "0.12"
@@ -166,16 +164,21 @@ jobs:
166164
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
167165
168166
- name: Configure npm
169-
run: npm config set shrinkwrap false
170-
171-
- name: Remove npm module(s) ${{ matrix.npm-rm }}
172-
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
173-
if: matrix.npm-rm != ''
167+
run: |
168+
if [[ "$(npm config get package-lock)" == "true" ]]; then
169+
npm config set package-lock false
170+
else
171+
npm config set shrinkwrap false
172+
fi
174173
175174
- name: Install npm module(s) ${{ matrix.npm-i }}
176175
run: npm install --save-dev ${{ matrix.npm-i }}
177176
if: matrix.npm-i != ''
178177

178+
- name: Remove npm module(s) ${{ matrix.npm-i }}
179+
run: npm rm --silent --save-dev ${{ matrix.npm-i }}
180+
if: matrix.npm-i != ''
181+
179182
- name: Setup Node.js version-specific dependencies
180183
shell: bash
181184
run: |

0 commit comments

Comments
 (0)