Skip to content

Consider dropping is-promise as a dependency #136

Open
@jonkoops

Description

Currently this module depends on is-promise, which allows 'promise like' objects with a then() method to be interpreted as a promise, for example:

isPromise({then:function () {...}}); // true

This has been historically done to handle polyfilling Promises in environments where they were not yet fully supported (e.g. the Promise global is not available). Since this is no longer needed as promises are widely supported it might be time to drop this dependency and instead use a simple instanceof Promise check, which would only allow standardized promises.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions