[Batch Delete] Fix check-types error and align the folder delete-info preflight

The batch pre-check passed a possibly-undefined RTK error into ApiError
(TS2345 in check-types); guard it like use-open-saved-search does.

The single-folder delete flow had the same preflight bug class the batch
flow just fixed, but worse: elementGetDeleteInfo failures were entirely
unhandled, silently falling back to the harmless recoverable-delete
wording even when deletion would be permanent, and the query
subscription was never released. Failures now raise the API error and
abort instead of opening a possibly under-warning dialog; the two
almost-identical modal configs are merged.

Refs #3961

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: xIrusux

assets/js/src/core/modules/element/actions/delete/use-batch-delete-confirm.tsx

@@ -9,6 +9,7 @@
  */
 
 import React from 'react'
+import { isUndefined } from 'lodash'
 import { useTranslation } from 'react-i18next'
 import { Accordion } from '@Pimcore/components/accordion/accordion'
 import { useFormModal } from '@Pimcore/components/modal/form-modal/hooks/use-form-modal'
@@ -53,7 +54,9 @@ export const useBatchDeleteConfirm = (): UseBatchDeleteConfirmReturn => {
       const response = await request
 
       if ('error' in response) {
-        trackError(new ApiError(response.error))
+        if (!isUndefined(response.error)) {
+          trackError(new ApiError(response.error))
+        }
         return null
       }
 

assets/js/src/core/modules/element/actions/delete/use-delete.tsx

@@ -15,7 +15,8 @@ import type { TreeNodeProps } from '@Pimcore/components/element-tree/node/tree-n
 import type { GridContextMenuProps } from '@Pimcore/components/grid/grid'
 import { Icon } from '@Pimcore/components/icon/icon'
 import { useFormModal } from '@Pimcore/components/modal/form-modal/hooks/use-form-modal'
-import trackError, { GeneralError } from '@Pimcore/modules/app/error-handler'
+import { isUndefined } from 'lodash'
+import trackError, { ApiError, GeneralError } from '@Pimcore/modules/app/error-handler'
 import { useRefreshGrid } from '@Pimcore/modules/element/actions/refresh-grid/use-refresh-grid'
 import { type Element, getElementKey } from '@Pimcore/modules/element/element-helper'
 import { api as elementApi } from '@Pimcore/modules/element/element-api-slice.gen'
@@ -91,39 +92,38 @@ export const useDelete = (elementType: ElementType, cacheKey?: string): UseDelet
     }
   }
 
+  const confirmFolderDelete = async (id: number, label: string, parentId?: number, onFinish?: () => void): Promise<void> => {
+    const request = dispatch(elementApi.endpoints.elementGetDeleteInfo.initiate({ elementType, id }))
+
+    try {
+      const { data, error } = await request
+
+      if (!isUndefined(error)) {
+        trackError(new ApiError(error))
+        return
+      }
+
+      const canUseRecycleBin = data?.canUseRecycleBin ?? true
+
+      modal.confirm({
+        title: t('element.delete.folder.title'),
+        content: <>
+          <p><span className={ styles.warningText }>{t(canUseRecycleBin ? 'element.delete.folder.small.note' : 'element.delete.folder.large.note')}</span></p>
+          <p>{t('element.delete.folder.question')}</p>
+          <b>/{label}</b>
+        </>,
+        cancelText: t('cancel'),
+        okText: t(canUseRecycleBin ? 'element.delete.folder.ok' : 'element.delete.folder.ok.permanent'),
+        onOk: async () => { await runDeleteJob(id, parentId, onFinish) }
+      })
+    } finally {
+      request.unsubscribe()
+    }
+  }
+
   const deleteElement = (id: number, label: string, parentId?: number, onFinish?: () => void, isFolder?: boolean): void => {
     if (isFolder === true) {
-      void dispatch(elementApi.endpoints.elementGetDeleteInfo.initiate({ elementType, id }))
-        .then(({ data }) => {
-          const canUseRecycleBin = data?.canUseRecycleBin ?? true
-
-          if (canUseRecycleBin) {
-            modal.confirm({
-              title: t('element.delete.folder.title'),
-              content: <>
-                <p><span className={ styles.warningText }>{t('element.delete.folder.small.note')}</span></p>
-                <p>{t('element.delete.folder.question')}</p>
-                <b>/{label}</b>
-              </>,
-              cancelText: t('cancel'),
-              okText: t('element.delete.folder.ok'),
-              onOk: async () => { await runDeleteJob(id, parentId, onFinish) }
-            })
-          } else {
-            modal.confirm({
-              title: t('element.delete.folder.title'),
-              content: <>
-                <p><span className={ styles.warningText }>{t('element.delete.folder.large.note')}</span></p>
-                <p>{t('element.delete.folder.question')}</p>
-                <b>/{label}</b>
-              </>,
-              cancelText: t('cancel'),
-              okText: t('element.delete.folder.ok.permanent'),
-
-              onOk: async () => { await runDeleteJob(id, parentId, onFinish) }
-            })
-          }
-        })
+      void confirmFolderDelete(id, label, parentId, onFinish)
     } else {
       modal.confirm({
         title: t('element.delete.confirmation.title'),