Skip to content

Why is NoticeType not just a simple Enum?  #96

Description

@lggwettmann

Hey guys,

loving the idea of the package so far. I found the installation steps for the NoticeTypes quite interesting, though. I'd be curious to learn why you choose for saving the NoticeTypes in the DB while there is a need to hardcode them in the rest of the code?

Why did you not go for a simple Enum or object which a) doesn't need DB access b) is much easier to set up?

I'd be happy to provide a pull-request in case this is something you were contemplating. I understand that this could mean a breaking change with a new version of pinax-notifications.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions