Commit 4ed1cbc
authored
## Problem
There are new parameters available on `query` for indexes with dedicated
read nodes:
- `scan_factor`
- `max_candidates`
These were pulled into the `2025-10` API release and need to be added to
the clients.
## Solution
- Regenerate core from OpenAPI and protos off of `2025-10` to pull in
`scan_factor` and `max_candidates`.
- Add `max_candidates` and `scan_factor` to the following resources and
thread things through the API:
- `VectorResourceAsyncio.query()` &&
`VectorResourceAsyncio.query_namespaces()`
- `VectorResource.query()` && `VectorResource.query_namepspaces()`
- `Index.query()` && `Index.query_namespaces()`
- `_IndexAsyncio.query()` && `_IndexAsyncio.query_namespaces()`
- `IndexRequestFactory.query_request()`
- `GRPCIndex.query()` && `GRPCIndex.query_namespaces()
## Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)
## Test Plan
CI - unit and integration tests
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Touches core query request construction and propagates new parameters
through both REST and gRPC layers; risk is mainly incorrect
serialization/forwarding or validation edge cases, mitigated by added
unit coverage.
>
> **Overview**
> Adds two new query tuning parameters, `scan_factor` and
`max_candidates`, to the `QueryRequest` schema and surfaces them through
all query entrypoints (`Index.query`, `query_namespaces`, sync/async
vector resources, and `GRPCIndex.query`).
>
> Regenerates the 2025-10 OpenAPI and protobuf bindings to include the
new fields (with validations and typing) and updates the request factory
to include them only when provided. Unit tests are expanded to assert
correct forwarding/omission behavior for REST, asyncio, and gRPC query
calls, and the generated API repo SHA is bumped.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0c40a43. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
1 parent 8a2d2e5 commit 4ed1cbc
File tree
14 files changed
+405
-45
lines changed- codegen
- pinecone
- core
- grpc/protos
- openapi/db_data/model
- db_data
- resources
- asyncio
- sync
- grpc
- openapi_support
- tests
- unit_grpc
- unit
- data
14 files changed
+405
-45
lines changedSubmodule apis updated from be7f2b2 to 103cc9d
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
| 203 | + | |
| 204 | + | |
203 | 205 | | |
204 | 206 | | |
205 | 207 | | |
| |||
209 | 211 | | |
210 | 212 | | |
211 | 213 | | |
212 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
213 | 217 | | |
214 | 218 | | |
215 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
| |||
114 | 116 | | |
115 | 117 | | |
116 | 118 | | |
| 119 | + | |
| 120 | + | |
117 | 121 | | |
118 | 122 | | |
119 | 123 | | |
| |||
130 | 134 | | |
131 | 135 | | |
132 | 136 | | |
| 137 | + | |
| 138 | + | |
133 | 139 | | |
134 | 140 | | |
135 | 141 | | |
| |||
194 | 200 | | |
195 | 201 | | |
196 | 202 | | |
| 203 | + | |
| 204 | + | |
197 | 205 | | |
198 | 206 | | |
199 | 207 | | |
| |||
295 | 303 | | |
296 | 304 | | |
297 | 305 | | |
| 306 | + | |
| 307 | + | |
298 | 308 | | |
299 | 309 | | |
300 | 310 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
945 | 945 | | |
946 | 946 | | |
947 | 947 | | |
| 948 | + | |
| 949 | + | |
948 | 950 | | |
949 | 951 | | |
950 | 952 | | |
| |||
970 | 972 | | |
971 | 973 | | |
972 | 974 | | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
973 | 983 | | |
974 | 984 | | |
975 | 985 | | |
| |||
1033 | 1043 | | |
1034 | 1044 | | |
1035 | 1045 | | |
| 1046 | + | |
| 1047 | + | |
1036 | 1048 | | |
1037 | 1049 | | |
1038 | 1050 | | |
| |||
1054 | 1066 | | |
1055 | 1067 | | |
1056 | 1068 | | |
| 1069 | + | |
| 1070 | + | |
1057 | 1071 | | |
1058 | 1072 | | |
1059 | 1073 | | |
| |||
1073 | 1087 | | |
1074 | 1088 | | |
1075 | 1089 | | |
| 1090 | + | |
| 1091 | + | |
1076 | 1092 | | |
1077 | 1093 | | |
1078 | 1094 | | |
| |||
1092 | 1108 | | |
1093 | 1109 | | |
1094 | 1110 | | |
| 1111 | + | |
| 1112 | + | |
1095 | 1113 | | |
1096 | 1114 | | |
1097 | 1115 | | |
| |||
1116 | 1134 | | |
1117 | 1135 | | |
1118 | 1136 | | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
1119 | 1145 | | |
1120 | 1146 | | |
1121 | 1147 | | |
| |||
1171 | 1197 | | |
1172 | 1198 | | |
1173 | 1199 | | |
| 1200 | + | |
| 1201 | + | |
1174 | 1202 | | |
1175 | 1203 | | |
1176 | 1204 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
728 | 728 | | |
729 | 729 | | |
730 | 730 | | |
| 731 | + | |
| 732 | + | |
731 | 733 | | |
732 | 734 | | |
733 | 735 | | |
| |||
832 | 834 | | |
833 | 835 | | |
834 | 836 | | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
835 | 845 | | |
836 | 846 | | |
837 | 847 | | |
| |||
846 | 856 | | |
847 | 857 | | |
848 | 858 | | |
| 859 | + | |
| 860 | + | |
849 | 861 | | |
850 | 862 | | |
851 | 863 | | |
| |||
861 | 873 | | |
862 | 874 | | |
863 | 875 | | |
| 876 | + | |
| 877 | + | |
864 | 878 | | |
865 | 879 | | |
866 | 880 | | |
| |||
877 | 891 | | |
878 | 892 | | |
879 | 893 | | |
| 894 | + | |
| 895 | + | |
880 | 896 | | |
881 | 897 | | |
882 | 898 | | |
| |||
897 | 913 | | |
898 | 914 | | |
899 | 915 | | |
| 916 | + | |
| 917 | + | |
900 | 918 | | |
901 | 919 | | |
902 | 920 | | |
| |||
909 | 927 | | |
910 | 928 | | |
911 | 929 | | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
912 | 938 | | |
913 | 939 | | |
914 | 940 | | |
| |||
965 | 991 | | |
966 | 992 | | |
967 | 993 | | |
| 994 | + | |
| 995 | + | |
968 | 996 | | |
969 | 997 | | |
970 | 998 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
59 | 61 | | |
60 | 62 | | |
61 | 63 | | |
| |||
73 | 75 | | |
74 | 76 | | |
75 | 77 | | |
| 78 | + | |
| 79 | + | |
76 | 80 | | |
77 | 81 | | |
78 | 82 | | |
| |||
0 commit comments