Fix missing readline error on Windows (#503)

## Problem

Missing `readline` dependency error when using `list_models` function.
Reported in #502

## Solution

This error was the result of the Cursor assistant putting some code into
`pinecone/scripts/repl.py` that should only have gone into
`scripts/repl.py` (and not been part of the package distribution).

This wasn't caught in CI because:
- ~`readline` is included in our dev dependencies, which are installed
in CI for testing purposes.~ `readline` is part of the python standard
library, so even though this reference was inadvertantly referenced, the
presence of these import statements should not cause a problem on dev
machines (mac) or CI (linux). However, `readline` is [not available for
Windows](python/cpython#90028) which is why
this error was occurring for the person who reported.
- Currently we do not have any Windows-specific testing in CI which is
why this error shipped unnoticed. So I implemented some new tests to
check the package can be installed on Windows in this PR.

## Type of Change

- [x] Bug fix (non-breaking change which fixes an issue)

## Test Plan

- Going to make a dev build and verify `list_models()` works in google
colab (where dev dependencies are not present) (7.0.2.dev1)
- Tested in Colab with 7.0.0 and 7.0.1 and could not reproduce the
problem; after further research it turns out this is a windows specific
problem. I should probably add some windows builds into the test matrix.
- Added new installation tests workflow to verify Windows install

Author: jhamon

.github/workflows/pr.yaml

@@ -57,6 +57,10 @@ jobs:
     secrets: inherit
     needs: unit-tests
 
+  testing-install:
+    uses: './.github/workflows/testing-install.yaml'
+    secrets: inherit
+
   package:
     name: Check packaging
     runs-on: ubuntu-latest

.github/workflows/testing-install.yaml

@@ -2,18 +2,22 @@ name: Installation Tests
 
 on:
   workflow_call:
+  workflow_dispatch:
 
 permissions:
   contents: read
   pull-requests: write
 
 jobs:
-  test-install:
+  install:
     runs-on: ${{ matrix.os }}
     strategy:
+      max-parallel: 3
+      fail-fast: true
       matrix:
-        os: [ubuntu-latest, windows-latest]
-        python: [3.9]
+        os: [ubuntu-latest, macos-latest]
+        python: ['3.9', '3.10', '3.11', '3.12', '3.13']
+
 
     steps:
       - name: Checkout code
@@ -32,13 +36,90 @@ jobs:
         run: python -m build --sdist --wheel
 
       - name: Install from built artifacts
+        shell: bash
         run: |
-          # Use the wheel if it's pure-python; fallback to sdist otherwise
           pip install dist/*.whl || pip install dist/*.tar.gz
 
       - name: Verify import & version
         run: |
           python - <<EOF
           import pinecone
           print("Imported OK, version:", pinecone.__version__)
+          from pinecone import Pinecone
           EOF
+
+      - name: Check a few basic functions
+        run: |
+          python - <<EOF
+          from pinecone import Pinecone
+
+          pc = Pinecone()
+          print("Indexes:", pc.list_indexes())
+          print("Collections:", pc.list_collections())
+          print("Backups:", pc.list_backups())
+          print("Assistants:", pc.assistant.list_assistants())
+          print("Inference Models:", pc.inference.list_models())
+          EOF
+        env:
+          PINECONE_API_KEY: ${{ secrets.PINECONE_API_KEY }}
+          PINECONE_ADDITIONAL_HEADERS: ${{ vars.PINECONE_ADDITIONAL_HEADERS }}
+
+  install-windows:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      max-parallel: 3
+      fail-fast: true
+      matrix:
+        os: [windows-latest]
+        python: ['3.9', '3.10', '3.11', '3.12', '3.13']
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Python ${{ matrix.python }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python }}
+
+      - name: Install build tools
+        run: |
+          python -m pip install --upgrade pip setuptools wheel build
+
+      - name: Build sdist & wheel
+        run: python -m build --sdist --wheel
+
+      - name: Install from built artifacts
+        shell: pwsh
+        run: |
+          $wheels = Get-ChildItem -Path "dist" -Filter "*.whl"
+          $sdists = Get-ChildItem -Path "dist" -Filter "*.tar.gz"
+          if ($wheels) {
+              pip install $wheels[0].FullName
+          }
+          elseif ($sdists) {
+              pip install $sdists[0].FullName
+          }
+          else {
+              throw "No wheel or sdist found in dist/"
+          }
+
+      - name: Verify import & version
+        shell: pwsh
+        run: |
+          python -c "import pinecone; print('Imported OK, version:', pinecone.__version__)"
+
+      - name: Check a few basic functions
+        shell: pwsh
+        run: |
+          python -c "
+          from pinecone import Pinecone
+          pc = Pinecone()
+          print('Indexes:', pc.list_indexes())
+          print('Collections:', pc.list_collections())
+          print('Backups:', pc.list_backups())
+          print('Assistants:', pc.assistant.list_assistants())
+          print('Inference Models:', pc.inference.list_models())
+          "
+        env:
+          PINECONE_API_KEY: ${{ secrets.PINECONE_API_KEY }}
+          PINECONE_ADDITIONAL_HEADERS: ${{ vars.PINECONE_ADDITIONAL_HEADERS }}

pinecone/scripts/repl.py

@@ -1,8 +1,5 @@
 import json
 from datetime import datetime
-import readline
-import os
-import atexit
 
 
 def custom_serializer(obj):
@@ -23,23 +20,3 @@ def install_json_repr_override(klass):
     klass.__repr__ = lambda self: json.dumps(
         self.to_dict(), indent=4, sort_keys=False, default=custom_serializer
     )
-
-
-def setup_readline_history():
-    """Setup readline history for the custom REPL."""
-    # Create .pinecone directory in user's home if it doesn't exist
-    history_dir = os.path.expanduser("~/.pinecone")
-    os.makedirs(history_dir, exist_ok=True)
-
-    # Set up history file
-    history_file = os.path.join(history_dir, "repl_history")
-
-    # Load history if it exists
-    if os.path.exists(history_file):
-        readline.read_history_file(history_file)
-
-    # Set history size
-    readline.set_history_length(1000)
-
-    # Save history on exit
-    atexit.register(readline.write_history_file, history_file)

pinecone/utils/repr_overrides.py

@@ -58,6 +58,7 @@ pinecone-plugin-interface = "^0.0.7"
 python-dateutil = ">=2.5.3"
 aiohttp = { version = ">=3.9.0", optional = true }
 aiohttp-retry = { version = "^2.9.1", optional = true }
+pinecone-plugin-assistant = "^1.6.0"
 
 [tool.poetry.group.types]
 optional = true
@@ -98,7 +99,6 @@ urllib3_mock = "0.3.3"
 responses = ">=0.8.1"
 ruff = "^0.9.3"
 beautifulsoup4 = "^4.13.3"
-pinecone-plugin-assistant = "^1.6.0"
 vprof = "^0.38"
 tuna = "^0.5.11"
 python-dotenv = "^1.1.0"