Commit 4e4d3a8
authored
## Problem
The typescript client's README has become quite bloated over time.
There's a lot of dense information stuffed into the top-level
`README.md` file which is not always conducive to people getting up and
running quickly, or finding information easily.
The `build-and-publish-docs` workflow is also not being run from the
`release` workflow due to recent changes to align with npm's new
[trusted publishing model](https://docs.npmjs.com/trusted-publishers).
Because we now have `environment: npm-publish` associated with the
release workflow/job, we need to handle secrets differently when passing
them to other jobs such as `integration-tests` and
`build-and-publish-docs`.
## Solution
Break the Typescript README up into a `/guides` folder struct (similar
to what was done in the [python
repo](https://github.com/pinecone-io/pinecone-python-client/tree/main/docs)).
The top-level repo `README` is more succinct, with a focus on getting up
and running quickly with client. We then use links to the nested
`guides/` markdown files for more specific examples and info.
**New Structure**
```
guides/
├── README.md # Navigation hub for all guides
├── faq.md # Frequently asked questions
│
├── index-management/
│ ├── serverless-indexes.md # Creating and managing serverless indexes
│ ├── pod-indexes.md # Creating and managing pod-based indexes
│ ├── collections.md # Working with collections
│ ├── backups.md # Backup and restore operations
│ └── shared-operations.md # Operations common to all index types
│
├── data-operations/
│ ├── working-with-vectors.md # Upsert, query, fetch, update, delete
│ ├── namespaces.md # Namespace management
│ ├── metadata-filtering.md # Filtering records by metadata
│ └── bulk-import.md # Importing large datasets from object storage
│
├── inference/
│ ├── inference-api.md # Standalone embedding and reranking
│ └── integrated-inference.md # Index-integrated inference operations
│
├── assistant/
│ ├── getting-started.md # Creating and targeting assistants
│ ├── chat.md # Chat operations and streaming
│ └── file-management.md # Upload, list, and manage files
│
├── typescript-features/
│ ├── type-safety.md # Leveraging generics for type safety
│ ├── async-patterns.md # Async/await patterns and concurrency
│ └── error-handling.md # Error handling best practices
│
└── upgrading/
├── v2-migration.md # Migration guide: v1.x → v2.x
└── v1-migration.md # Migration guide: v0.x → v1.x
```
Additionally, I've updated the `release.yml` workflow to explicitly pass
secrets (`PINECONE_API_KEY` / `VERCEL_TOKEN`) to the child workflows:
`integration-tests`, and `build-and-publish-docs`.
Hopefully, this resolves the skipped workflows when running the release.
Also updated some doc comments and test cruft to clean some additional
things up.
## Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [X] Infrastructure change (CI configs, etc)
- [X] Non-code change (docs, etc)
- [ ] None of the above: (explain here)
## Test Plan
These changes are all documentation and infrastructure related. In order
to test the release flow properly, we'll need to re-run a release and
see if the child workflows are properly triggered with secrets. It's
possible we may need to reconfigure the secrets for the repo to live
inside of the `npm-publish` environment.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Medium risk because it changes GitHub Actions secret wiring for
reusable workflows, which could break releases/CI if environment secrets
are misconfigured; documentation changes are otherwise low risk.
>
> **Overview**
> **Docs overhaul:** Replaces the bloated top-level `README.md` with a
shorter quickstart-focused version and links out to a new structured
`guides/` documentation tree (index management, data ops, inference,
assistant, TS features, FAQ, upgrading).
>
> **CI fix:** Updates reusable workflow secret requirements by adding
`VERCEL_TOKEN` to `pr.yml`’s `workflow_call` secrets and changing
`release.yml` to explicitly pass required secrets to the
`integration-tests` and `build-and-publish-docs` reusable workflows
instead of `secrets: inherit`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
3b2bd09. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
- https://app.asana.com/0/0/1213055949284764
1 parent ead0109 commit 4e4d3a8
File tree
47 files changed
+5188
-2185
lines changed- .github/workflows
- guides
- assistant
- data-operations
- index-management
- inference
- typescript-features
- upgrading
- src
- assistant/control/__tests__
- control/__tests__
- data
- __tests__/vectors
- inference/__tests__
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
47 files changed
+5188
-2185
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
191 | 193 | | |
192 | 194 | | |
193 | 195 | | |
194 | | - | |
| 196 | + | |
| 197 | + | |
195 | 198 | | |
196 | 199 | | |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
0 commit comments