Skip to content

Commit 576fe90

Browse files
pass git token with the create draft release with notes job (#377)
## Problem The release workflow currently fails even with successful deploys due to the `Create draft release with notes (prod)` job: https://github.com/pinecone-io/pinecone-ts-client/actions/runs/21552112656/job/62102608939 ## Solution Pass `GH_TOKEN: ${{ github.token }}` in the create draft release notes step. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [X] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan N/A <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk CI-only changes; main impact is on GitHub Release creation permissions plus lockfile metadata churn that should not affect runtime code. > > **Overview** > Fixes the production release workflow by explicitly providing `GH_TOKEN: ${{ github.token }}` to the `gh release create` step so draft releases with generated notes can be created successfully. > > Separately updates `.prettierignore` to exclude `package-lock.json`, and refreshes `package-lock.json` with minor metadata changes (e.g., removing `peer` flags on several dev dependencies). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6f44acc. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 193d1b3 commit 576fe90

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,8 @@ jobs:
182182
- name: Create draft release with notes (prod)
183183
if: github.event.inputs.releaseMode == 'prod'
184184
shell: bash
185+
env:
186+
GH_TOKEN: ${{ github.token }}
185187
run: |
186188
gh release create "v${{ steps.version-bump-prod.outputs.version }}" \
187189
--draft \

.prettierignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ dist
22
node_modules
33
codegen
44
src/pinecone-generated-ts-fetch
5-
.cursor
5+
.cursor
6+
package-lock.json

package-lock.json

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)