don't use generated helper funcs for determining spec, just hand roll it - add test

Author: austin-denoble

src/control/__tests__/configureIndex.test.ts

@@ -1,4 +1,4 @@
-import { configureIndex } from '../configureIndex';
+import { configureIndex, getIndexSpecType } from '../configureIndex';
 import { ManageIndexesApi } from '../../pinecone-generated-ts-fetch/db_control';
 import type {
   ConfigureIndexOperationRequest,
@@ -275,3 +275,66 @@ describe('configureIndex', () => {
     expect(IOA.configureIndex).not.toHaveBeenCalled();
   });
 });
+
+describe('getIndexSpecType', () => {
+  // IndexModelSpecFromJSON merges BYOC, PodBased, Serverless FromJSON results,
+  // so spec can have pod/serverless/byoc all present with some undefined.
+  // getIndexSpecType must classify by defined value, not key presence.
+
+  test('returns serverless when only serverless has a defined value (merged FromJSON shape)', () => {
+    const spec = {
+      pod: undefined,
+      serverless: {
+        cloud: 'aws',
+        region: 'us-east-1',
+        readCapacity: { mode: 'OnDemand', status: { state: 'Ready' } },
+      },
+      byoc: undefined,
+    };
+    expect(getIndexSpecType(spec as Parameters<typeof getIndexSpecType>[0])).toBe(
+      'serverless',
+    );
+  });
+
+  test('returns pod when only pod has a defined value (merged FromJSON shape)', () => {
+    const spec = {
+      pod: {
+        environment: 'us-east1-gcp',
+        replicas: 4,
+        shards: 1,
+        pods: 4,
+        podType: 'p2.x2',
+      },
+      serverless: undefined,
+      byoc: undefined,
+    };
+    expect(getIndexSpecType(spec as Parameters<typeof getIndexSpecType>[0])).toBe(
+      'pod',
+    );
+  });
+
+  test('returns byoc when only byoc has a defined value (merged FromJSON shape)', () => {
+    const spec = {
+      pod: undefined,
+      serverless: undefined,
+      byoc: {
+        environment: 'my-env',
+        readCapacity: { mode: 'OnDemand', status: { state: 'Ready' } },
+      },
+    };
+    expect(getIndexSpecType(spec as Parameters<typeof getIndexSpecType>[0])).toBe(
+      'byoc',
+    );
+  });
+
+  test('returns unknown for null or non-object', () => {
+    expect(
+      getIndexSpecType(null as unknown as Parameters<typeof getIndexSpecType>[0]),
+    ).toBe('unknown');
+    expect(
+      getIndexSpecType(
+        undefined as unknown as Parameters<typeof getIndexSpecType>[0],
+      ),
+    ).toBe('unknown');
+  });
+});

src/control/configureIndex.ts

@@ -1,13 +1,11 @@
 import {
   ManageIndexesApi,
   IndexModel,
+  type IndexModelSpec,
   ConfigureIndexRequest,
   ConfigureIndexRequestEmbed,
   ConfigureIndexRequestSpec,
   X_PINECONE_API_VERSION,
-  instanceOfBYOC,
-  instanceOfPodBased,
-  instanceOfServerless,
 } from '../pinecone-generated-ts-fetch/db_control';
 import { PineconeArgumentError } from '../errors';
 import type { IndexName } from './types';
@@ -125,22 +123,37 @@ export const configureIndex = (api: ManageIndexesApi) => {
 };
 
 /**
- * Helper function to determine the spec type of an index using generated helper functions.
- * @param spec - The IndexModelSpec from describeIndex
+ * Determines the spec type of an index by which spec key has a defined value.
+ *
+ * @param spec - The IndexModelSpec from describeIndex (may have multiple keys, only one defined)
  * @returns The spec type: 'pod', 'serverless', or 'byoc'
+ * @internal Exported for testing
  */
-const getIndexSpecType = (
-  spec: any,
+export const getIndexSpecType = (
+  spec: IndexModelSpec,
 ): 'pod' | 'serverless' | 'byoc' | 'unknown' => {
-  if (instanceOfPodBased(spec)) {
-    return 'pod';
+  if (spec == null || typeof spec !== 'object') {
+    return 'unknown';
   }
-  if (instanceOfServerless(spec)) {
+  // Classify by which key has a defined object value (order is arbitrary but deterministic).
+  // Use 'in' to narrow the union before reading the property.
+  if (
+    'serverless' in spec &&
+    spec.serverless != null &&
+    typeof spec.serverless === 'object'
+  ) {
     return 'serverless';
   }
-  if (instanceOfBYOC(spec)) {
+  if (
+    'byoc' in spec &&
+    spec.byoc != null &&
+    typeof spec.byoc === 'object'
+  ) {
     return 'byoc';
   }
+  if ('pod' in spec && spec.pod != null && typeof spec.pod === 'object') {
+    return 'pod';
+  }
   return 'unknown';
 };