Skip to content

Commit ab803a4

Browse files
committed
fix uncontrolled error
1 parent 86db882 commit ab803a4

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

frontend/app/src/components/embedding-models/UpdateEmbeddingModelForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ const updatedAtAccessor = getDatetimeAccessor('updated_at');
152152
const stringCredentialSchema = z.string().optional();
153153
const dictCredentialSchema = zodJsonText();
154154

155-
const stringCredentialAccessor = fieldAccessor<UpdateEmbeddingModel, 'credentials'>('credentials');
155+
const stringCredentialAccessor = fieldAccessor<UpdateEmbeddingModel, 'credentials', ''>('credentials');
156156
const dictCredentialAccessor: GeneralSettingsFieldAccessor<UpdateEmbeddingModel, string> = {
157157
path: ['credentials'],
158158
get (data) {

frontend/app/src/components/llm/UpdateLLMForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ const updatedAtAccessor = getDatetimeAccessor('updated_at');
159159
const stringCredentialSchema = z.string().optional();
160160
const dictCredentialSchema = zodJsonText();
161161

162-
const stringCredentialAccessor = fieldAccessor<UpdateLLM, 'credentials'>('credentials');
162+
const stringCredentialAccessor = fieldAccessor<UpdateLLM, 'credentials'>('credentials', '');
163163
const dictCredentialAccessor: GeneralSettingsFieldAccessor<UpdateLLM, string> = {
164164
path: ['credentials'],
165165
get (data) {

frontend/app/src/components/reranker/UpdateRerankerForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ const updatedAtAccessor = getDatetimeAccessor('updated_at');
166166
const stringCredentialSchema = z.string().optional();
167167
const dictCredentialSchema = zodJsonText();
168168

169-
const stringCredentialAccessor = fieldAccessor<UpdateReranker, 'credentials'>('credentials');
169+
const stringCredentialAccessor = fieldAccessor<UpdateReranker, 'credentials'>('credentials', '');
170170
const dictCredentialAccessor: GeneralSettingsFieldAccessor<UpdateReranker, string> = {
171171
path: ['credentials'],
172172
get (data) {

frontend/app/src/components/settings-form/GeneralSettingsField.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ export interface GeneralSettingsFieldAccessor<Data, FieldData> {
1414
set: (data: Readonly<Data>, value: FieldData) => Data,
1515
}
1616

17-
export function fieldAccessor<Data, Key extends keyof Data> (key: Key): GeneralSettingsFieldAccessor<Data, Data[Key]> {
17+
export function fieldAccessor<Data, Key extends keyof Data> (key: Key, defaultValue?: Data[Key]): GeneralSettingsFieldAccessor<Data, Data[Key]> {
1818
return {
1919
path: [key],
20-
get: (data) => data[key],
20+
get: (data) => data[key] ?? defaultValue as Data[Key],
2121
set: (data, value) => {
2222
return {
2323
...data,

0 commit comments

Comments
 (0)