Merge pull request #23 from qiancai/fix-github-mention-postprocess

markdown-translator: post-process GitHub mention links after JA translation

Author: shhdgit

markdown-translator/src/GithubMentions.js

@@ -0,0 +1,18 @@
+import * as fs from "fs";
+
+const GITHUB_MENTION_LINK_REGEX =
+  /@\s*\[[^\]]*\]\(https?:\/\/github\.com\/([^)\s\/]+)\/?\)/g;
+
+export const fixMarkdownGithubMentions = (markdown) =>
+  markdown.replaceAll(GITHUB_MENTION_LINK_REGEX, "@[$1](https://github.com/$1)");
+
+export const postProcessFileGithubMentions = (filePath) => {
+  if (!fs.existsSync(filePath)) return;
+
+  const content = fs.readFileSync(filePath, "utf8");
+  const updatedContent = fixMarkdownGithubMentions(content);
+
+  if (updatedContent !== content) {
+    fs.writeFileSync(filePath, updatedContent);
+  }
+};

markdown-translator/src/index_ja.js

@@ -23,6 +23,7 @@ import { visit } from "unist-util-visit";
 import { getMdFileList, writeFileSync, handleAstNode } from "./lib.js";
 import { loadVariables, variablesReplace } from "./variables.js";
 import { postProcessFileFrontmatterAliases } from "./frontmatterAliases.js";
+import { postProcessFileGithubMentions } from "./GithubMentions.js";
 
 const pSum = {
   sum: 0,
@@ -128,6 +129,7 @@ const main = async (dir = "markdowns", outputDir = "output") => {
     replaceDeprecatedContent(filePath);
     await translateSingleMdToJa(filePath, outputFilePath);
     postProcessFileFrontmatterAliases(outputFilePath, "ja");
+    postProcessFileGithubMentions(outputFilePath);
     // break;
   }
 

markdown-translator/test/GithubMentions.test.js

@@ -0,0 +1,58 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+
+import {
+  postProcessFileGithubMentions,
+  fixMarkdownGithubMentions,
+} from "../src/GithubMentions.js";
+
+test("fixMarkdownGithubMentions: replaces github profile mention links", () => {
+  const input = "Thanks @ [Aki](https://github.com/aki).\n";
+  const expected = "Thanks @ [aki](https://github.com/aki).\n";
+
+  assert.equal(fixMarkdownGithubMentions(input), expected);
+});
+
+test("fixMarkdownGithubMentions: leaves non-github links unchanged", () => {
+  const input = "Thanks @ [Aki](https://example.com/aki).\n";
+  assert.equal(fixMarkdownGithubMentions(input), input);
+});
+
+test("fixMarkdownGithubMentions: handles multiple mentions in one line", () => {
+  const input =
+    "Reviewers: @ [Alpha](https://github.com/alpha), @ [Beta](https://github.com/beta/)\n";
+  const expected =
+    "Reviewers: @ [alpha](https://github.com/alpha), @ [beta](https://github.com/beta)\n";
+  assert.equal(fixMarkdownGithubMentions(input), expected);
+});
+
+test("postProcessFileGithubMentions: updates file in-place", () => {
+  const tempDir = fs.mkdtempSync(
+    path.join(os.tmpdir(), "github-mentions-postprocess-")
+  );
+
+  try {
+    const filePath = path.join(tempDir, "doc.md");
+    fs.writeFileSync(
+      filePath,
+      "Reviewers: @ [Alpha](https://github.com/alpha), @ [Beta](https://github.com/beta/)\n"
+    );
+
+    postProcessFileGithubMentions(filePath);
+
+    const updated = fs.readFileSync(filePath, "utf8");
+    assert.equal(
+      updated,
+      "Reviewers: @ [alpha](https://github.com/alpha), @ [beta](https://github.com/beta)\n"
+    );
+
+    assert.doesNotThrow(() =>
+      postProcessFileGithubMentions(path.join(tempDir, "missing.md"))
+    );
+  } finally {
+    fs.rmSync(tempDir, { recursive: true, force: true });
+  }
+});