Skip to content

Commit 45a71f1

Browse files
authored
conprof: use debug=1 for goroutine profile to avoid STW (#205) (#223)
close #220
1 parent 44845a2 commit 45a71f1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

component/conprof/scrape/manager.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,9 @@ func goAppProfilingConfig(cfg config.ContinueProfilingConfig) *config.ProfilingC
327327
Path: "/debug/pprof/heap",
328328
},
329329
"goroutine": &config.PprofProfilingConfig{
330-
Path: "/debug/pprof/goroutine",
331-
Params: map[string]string{"debug": "2"},
330+
Path: "/debug/pprof/goroutine",
331+
// debug=2 causes STW when collecting the stacks. See https://github.com/pingcap/tidb/issues/48695.
332+
Params: map[string]string{"debug": "1"},
332333
},
333334
"mutex": &config.PprofProfilingConfig{
334335
Path: "/debug/pprof/mutex",

0 commit comments

Comments
 (0)