Skip to content

Commit 0bbc93c

Browse files
tiancaiamaoclaude
andcommitted
skills: add CTE masking test to column-masking-auto-validation
This commit updates the column masking auto-validation skill to include the new CTE masking test case. Changes: - Add tests/integrationtest/t/privilege/column_masking_cte.test to test plan - Add P0-CORE-03 scenario for AT RESULT semantics with CTE - Add it_column_masking_cte step to validation script Co-Authored-By: Claude <noreply@anthropic.com>
1 parent ff4e873 commit 0bbc93c

3 files changed

Lines changed: 44 additions & 0 deletions

File tree

.agents/skills/column-masking-auto-validation/references/column-masking-test-plan.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ Execution policy:
5858

5959
- Integration:
6060
- `tests/integrationtest/t/privilege/column_masking_policy.test`
61+
- `tests/integrationtest/t/privilege/column_masking_cte.test`
6162
- Unit:
6263
- `pkg/ddl/masking_policy_test.go`
6364
- `pkg/planner/core/masking_policy_projection_test.go`

.agents/skills/column-masking-auto-validation/references/p0-scenario-matrix.json

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,48 @@
235235
"steps": ["it_column_masking", "ut_planner"]
236236
}
237237
},
238+
{
239+
"id": "P0-CORE-03",
240+
"scenario": "AT RESULT semantics with CTE",
241+
"coverage_cases": [
242+
{
243+
"name": "Basic CTE masking (IT-MASK-P0-CTE-001)",
244+
"file": "tests/integrationtest/t/privilege/column_masking_cte.test"
245+
},
246+
{
247+
"name": "CTE with RESTRICT ON (IT-MASK-P0-CTE-002)",
248+
"file": "tests/integrationtest/t/privilege/column_masking_cte.test"
249+
},
250+
{
251+
"name": "CTE AT RESULT semantics (HAVING, ORDER BY) (IT-MASK-P0-CTE-003)",
252+
"file": "tests/integrationtest/t/privilege/column_masking_cte.test"
253+
},
254+
{
255+
"name": "CTE multiple references (IT-MASK-P0-CTE-004)",
256+
"file": "tests/integrationtest/t/privilege/column_masking_cte.test"
257+
},
258+
{
259+
"name": "CTE with current_role() (IT-MASK-P0-CTE-005)",
260+
"file": "tests/integrationtest/t/privilege/column_masking_cte.test"
261+
},
262+
{
263+
"name": "CTE with MASK_PARTIAL (IT-MASK-P0-CTE-006)",
264+
"file": "tests/integrationtest/t/privilege/column_masking_cte.test"
265+
},
266+
{
267+
"name": "CTE with CONCAT expression (IT-MASK-P0-CTE-007)",
268+
"file": "tests/integrationtest/t/privilege/column_masking_cte.test"
269+
},
270+
{
271+
"name": "Recursive CTE with masking (IT-MASK-P0-CTE-008)",
272+
"file": "tests/integrationtest/t/privilege/column_masking_cte.test"
273+
}
274+
],
275+
"rule": {
276+
"type": "steps_pass",
277+
"steps": ["it_column_masking_cte"]
278+
}
279+
},
238280
{
239281
"id": "P0-RES-01",
240282
"scenario": "RESTRICT ON INSERT INTO ... SELECT",

.agents/skills/column-masking-auto-validation/scripts/run_validation.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ if [[ "${SKIP_TESTS}" -eq 0 ]]; then
110110
run_step "ut_failpoint_disable" "make failpoint-disable"
111111

112112
run_step "it_column_masking" "pushd tests/integrationtest >/dev/null && ./run-tests.sh -r privilege/column_masking_policy && popd >/dev/null"
113+
run_step "it_column_masking_cte" "pushd tests/integrationtest >/dev/null && ./run-tests.sh -r privilege/column_masking_cte && popd >/dev/null"
113114
run_step "it_expression_builtin" "pushd tests/integrationtest >/dev/null && ./run-tests.sh -r expression/builtin && popd >/dev/null"
114115

115116
if [[ "${WITH_LINT}" -eq 1 ]]; then

0 commit comments

Comments
 (0)