executor: rename ordered window helper

Author: hawkingrei

pkg/executor/windows/builder.go

@@ -27,18 +27,18 @@ import (
 	"github.com/pingcap/tidb/pkg/sessionctx"
 )
 
-// BuildStream constructs the executor for a stream window physical plan. The
-// caller must ensure that the child already provides the required order.
-func BuildStream(sctx sessionctx.Context, v *physicalop.PhysicalWindow, childExec exec.Executor) (exec.Executor, error) {
+// BuildOrdered constructs the executor for a window plan whose child already
+// provides the required partition/order property.
+func BuildOrdered(sctx sessionctx.Context, v *physicalop.PhysicalWindow, childExec exec.Executor) (exec.Executor, error) {
 	windowExec, err := Build(sctx, v, childExec, true)
 	if err != nil {
 		return nil, err
 	}
 	pipelinedExec, ok := windowExec.(*PipelinedWindowExec)
 	if !ok {
-		return nil, errors.New("stream window must be built with pipelined window executor")
+		return nil, errors.New("ordered window must be built with pipelined window executor")
 	}
-	return &StreamWindowExec{PipelinedWindowExec: pipelinedExec}, nil
+	return &OrderedWindowExec{PipelinedWindowExec: pipelinedExec}, nil
 }
 
 // Build constructs the concrete executor for a window physical plan.

pkg/executor/windows/pipelined_window.go

@@ -77,9 +77,9 @@ type PipelinedWindowExec struct {
 	initializedSlidingWindow bool
 }
 
-// StreamWindowExec executes windows whose input already satisfies the required
+// OrderedWindowExec executes windows whose input already satisfies the required
 // partition/order property.
-type StreamWindowExec struct {
+type OrderedWindowExec struct {
 	*PipelinedWindowExec
 }
 

pkg/executor/windows/window_executor_test.go

@@ -56,7 +56,7 @@ func TestWindowExecutorsBasic(t *testing.T) {
 	}
 }
 
-func TestBuildStreamWindowExec(t *testing.T) {
+func TestBuildOrderedWindowExec(t *testing.T) {
 	store := testkit.CreateMockStore(t)
 	tk := testkit.NewTestKit(t, store)
 	tk.MustExec("set @@tidb_enable_pipelined_window_function = 0")
@@ -83,20 +83,20 @@ func TestBuildStreamWindowExec(t *testing.T) {
 	windowSchema.Append(&expression.Column{Index: 2, UniqueID: 3, RetType: types.NewFieldType(mysql.TypeLonglong)})
 	windowPlan := physicalWindowForTest(sctx.GetPlanCtx(), windowSchema, colA, colB, windowFunc)
 
-	streamExec, err := windowexec.BuildStream(sctx, windowPlan, childExec)
+	orderedExec, err := windowexec.BuildOrdered(sctx, windowPlan, childExec)
 	require.NoError(t, err)
-	require.IsType(t, &windowexec.StreamWindowExec{}, streamExec)
+	require.IsType(t, &windowexec.OrderedWindowExec{}, orderedExec)
 
 	ctx := context.Background()
-	require.NoError(t, streamExec.Open(ctx))
+	require.NoError(t, orderedExec.Open(ctx))
 	defer func() {
-		require.NoError(t, streamExec.Close())
+		require.NoError(t, orderedExec.Close())
 	}()
 
-	chk := exec.NewFirstChunk(streamExec)
+	chk := exec.NewFirstChunk(orderedExec)
 	rows := make([]string, 0, 4)
 	for {
-		require.NoError(t, streamExec.Next(ctx, chk))
+		require.NoError(t, orderedExec.Next(ctx, chk))
 		if chk.NumRows() == 0 {
 			break
 		}