Commit 8e5eb75
dumpling/export: fail loudly on boundary-sampling errors and unknown column types
- Boundary-sampling failure used to log a warning and `break`, which
silently dropped into the post-loop branches. On a first-iteration
failure the table was dumped as a single un-chunked task; on a later
failure the dump emitted an oversized "tail" chunk from the last
good boundary to +∞. Either way the caller never saw the failure.
Return the error so the job-level retry/backoff applies.
- Replace the silent `fmt.Sprintf("%v", v)` fallback in the row-scan
type switch with an explicit error referencing the column name and
Go type. The MySQL driver returns string/[]byte/int*/float* for the
supported boundary types (parseTime is not enabled in
GetDriverConfig), so any other type means a future caller widened
the chunking surface beyond what the WHERE-clause builders support
and we should fail loudly rather than emit a malformed predicate.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 3cf73d2 commit 8e5eb75
1 file changed
Lines changed: 36 additions & 22 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
198 | 205 | | |
199 | 206 | | |
200 | 207 | | |
| |||
207 | 214 | | |
208 | 215 | | |
209 | 216 | | |
210 | | - | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
211 | 225 | | |
212 | 226 | | |
213 | 227 | | |
214 | 228 | | |
215 | | - | |
| 229 | + | |
216 | 230 | | |
217 | 231 | | |
218 | 232 | | |
| |||
0 commit comments