Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add REPLICAS, substitute the FOLLOWERS keywords in placement rule syntax #47303

Open
Tracked by #45384
nolouch opened this issue Sep 26, 2023 · 1 comment · May be fixed by #47467
Open
Tracked by #45384

add REPLICAS, substitute the FOLLOWERS keywords in placement rule syntax #47303

nolouch opened this issue Sep 26, 2023 · 1 comment · May be fixed by #47467
Assignees
@nikzayn
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@nolouch
Copy link
Member

nolouch commented Sep 26, 2023 •
edited
Loading

Enhancement

The current syntax is confusing for users, as shown in the following examples:

CREATE PLACEMENT POLICY fivereplicas FOLLOWERS=4;
CREATE TABLE t1 (a INT) PLACEMENT POLICY=fivereplicas;

To improve clarity and directness, the syntax can be revised to:

CREATE PLACEMENT POLICY fivereplicas REPLICAS=5;
CREATE TABLE t1 (a INT)  PLACEMENT POLICY=fivereplicas;
@nolouch nolouch added the type/enhancement The issue or PR belongs to an enhancement. label Sep 26, 2023
@nolouch nolouch mentioned this issue Sep 26, 2023
Closed
33 tasks
@nikzayn
Copy link

nikzayn commented Oct 8, 2023

I will take this up.

/assign

nikzayn added a commit to nikzayn/tidb that referenced this issue Oct 8, 2023
@nikzayn
feat: added REPLICAS to substitute the FOLLOWERS keywords in placemen…
57a51e7 
…t rule syntax (pingcap#47303)

Signed-off-by: nikzayn <[email protected]>
@nikzayn nikzayn linked a pull request Oct 8, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikzayn nikzayn

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added REPLICAS to substitute the FOLLOWERS keywords in placemen… nikzayn/tidb
2 participants
@nolouch @nikzayn