storage: Use different names for block bg pool (#5867)

ref #5807

Author: breezewish

dbms/src/Interpreters/Context.cpp

@@ -1366,7 +1366,7 @@ BackgroundProcessingPool & Context::initializeBackgroundPool(UInt16 pool_size)
 {
     auto lock = getLock();
     if (!shared->background_pool)
-        shared->background_pool = std::make_shared<BackgroundProcessingPool>(pool_size);
+        shared->background_pool = std::make_shared<BackgroundProcessingPool>(pool_size, "bg-");
     return *shared->background_pool;
 }
 
@@ -1380,7 +1380,7 @@ BackgroundProcessingPool & Context::initializeBlockableBackgroundPool(UInt16 poo
 {
     auto lock = getLock();
     if (!shared->blockable_background_pool)
-        shared->blockable_background_pool = std::make_shared<BackgroundProcessingPool>(pool_size);
+        shared->blockable_background_pool = std::make_shared<BackgroundProcessingPool>(pool_size, "bg-block-");
     return *shared->blockable_background_pool;
 }
 

dbms/src/Storages/BackgroundProcessingPool.cpp

@@ -82,15 +82,18 @@ void BackgroundProcessingPool::TaskInfo::wake()
 }
 
 
-BackgroundProcessingPool::BackgroundProcessingPool(int size_)
+BackgroundProcessingPool::BackgroundProcessingPool(int size_, std::string thread_prefix_)
     : size(size_)
+    , thread_prefix(thread_prefix_)
     , thread_ids_counter(size_)
 {
-    LOG_FMT_INFO(&Poco::Logger::get("BackgroundProcessingPool"), "Create BackgroundProcessingPool with {} threads", size);
+    LOG_FMT_INFO(Logger::get("BackgroundProcessingPool"), "Create BackgroundProcessingPool, prefix={} n_threads={}", thread_prefix, size);
 
     threads.resize(size);
-    for (auto & thread : threads)
-        thread = std::thread([this] { threadFunction(); });
+    for (size_t i = 0; i < size; ++i)
+    {
+        threads[i] = std::thread([this, i] { threadFunction(i); });
+    }
 }
 
 
@@ -142,11 +145,10 @@ BackgroundProcessingPool::~BackgroundProcessingPool()
 }
 
 
-void BackgroundProcessingPool::threadFunction()
+void BackgroundProcessingPool::threadFunction(size_t thread_idx)
 {
     {
-        static std::atomic_uint64_t tid{0};
-        const auto name = "BkgPool" + std::to_string(tid++);
+        const auto name = thread_prefix + std::to_string(thread_idx);
         setThreadName(name.data());
         is_background_thread = true;
         addThreadId(getTid());

dbms/src/Storages/BackgroundProcessingPool.h

@@ -81,7 +81,7 @@ class BackgroundProcessingPool
     using TaskHandle = std::shared_ptr<TaskInfo>;
 
 
-    explicit BackgroundProcessingPool(int size_);
+    explicit BackgroundProcessingPool(int size_, std::string thread_prefix_);
 
     size_t getNumberOfThreads() const { return size; }
 
@@ -109,6 +109,7 @@ class BackgroundProcessingPool
     using Threads = std::vector<std::thread>;
 
     const size_t size;
+    const std::string thread_prefix;
     static constexpr double sleep_seconds = 10;
     static constexpr double sleep_seconds_random_part = 1.0;
 
@@ -123,8 +124,7 @@ class BackgroundProcessingPool
     std::atomic<bool> shutdown{false};
     std::condition_variable wake_event;
 
-
-    void threadFunction();
+    void threadFunction(size_t thread_idx);
 };
 
 using BackgroundProcessingPoolPtr = std::shared_ptr<BackgroundProcessingPool>;