Skip to content

Commit 9a8a32d

Browse files
a-congAlexandra Cong
authored andcommitted
use WrapError for error handling
1 parent 1cf984e commit 9a8a32d

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

cdc/model/sink.go

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1170,7 +1170,10 @@ func (d *DDLEvent) applySinkRouting(sinkRouter *dispatcher.SinkRouter) error {
11701170
p := parser.New()
11711171
stmts, _, err := p.Parse(d.Query, d.Charset, d.Collate)
11721172
if err != nil {
1173-
return errors.Annotate(err, "failed to parse DDL for sink routing")
1173+
log.Error("failed to parse DDL for sink routing",
1174+
zap.String("query", d.Query),
1175+
zap.Error(err))
1176+
return errors.WrapError(errors.ErrDispatcherFailed, err)
11741177
}
11751178
if len(stmts) == 0 {
11761179
return nil
@@ -1187,7 +1190,11 @@ func (d *DDLEvent) applySinkRouting(sinkRouter *dispatcher.SinkRouter) error {
11871190

11881191
sourceTables, err := dmparser.FetchDDLTables(defaultSchema, stmts[0], conn.LCTableNamesSensitive)
11891192
if err != nil {
1190-
return errors.Annotate(err, "failed to fetch source tables for sink routing")
1193+
log.Error("failed to fetch source tables for sink routing",
1194+
zap.String("query", d.Query),
1195+
zap.String("defaultSchema", defaultSchema),
1196+
zap.Error(err))
1197+
return errors.WrapError(errors.ErrDispatcherFailed, err)
11911198
}
11921199

11931200
// Route each source table to get target schema and table in the same order
@@ -1215,7 +1222,11 @@ func (d *DDLEvent) applySinkRouting(sinkRouter *dispatcher.SinkRouter) error {
12151222
// Use RenameDDLTable to rewrite the query
12161223
routedQuery, err := dmparser.RenameDDLTable(stmts[0], targetTables)
12171224
if err != nil {
1218-
return errors.Annotate(err, "failed to rewrite DDL for sink routing")
1225+
log.Error("failed to rewrite DDL for sink routing",
1226+
zap.String("query", d.Query),
1227+
zap.Any("targetTables", targetTables),
1228+
zap.Error(err))
1229+
return errors.WrapError(errors.ErrDispatcherFailed, err)
12191230
}
12201231

12211232
d.Query = routedQuery

0 commit comments

Comments
 (0)