Skip to content

Conversation

@SoohanBae
Copy link

Describe your changes

why we need this pr?
• Enables automatic specification of the Python version on PyPI
• Clarifies dependency management

Issue ticket number and link

if it has issues, add them

Checklist before requesting a review

  • [v] I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@eeliu eeliu requested review from Copilot and eeliu June 12, 2025 07:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Python version requirements and appropriate classifiers to facilitate dependency management and improve package metadata on PyPI, while also updating the package version.

  • Added python_requires and classifiers in setup.py.
  • Updated the version value in the plugin’s init.py.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
setup.py Added python version requirement and classifiers.
plugins/PY/pinpointPy/init.py Updated version and maintained module interface.
Comments suppressed due to low confidence (1)

plugins/PY/pinpointPy/init.py:32

  • There appears to be a missing comma between 'use_thread_local_context' and 'set_agent' in the all list, which could inadvertently concatenate the two strings.
__all__ = ['monkey_patch_for_pinpoint', 'use_thread_local_context' 'set_agent', 'app_id', 'app_name', 'gen_tid', 'get_logger', 'PinTransaction', 'GenPinHeader', 'PinHeader']

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants