Skip to content

Prevent potential panic asyncProducer #110

@rlaxodbs0

Description

@rlaxodbs0

In current implementation of asyncProducer kafka wrapper, there is a potential for panic without recovery.

go func() {
defer close(wrapped.inputContext)
defer close(wrapped.input)
defer close(wrapped.successes)
defer close(wrapped.errors)

go func() {
defer close(wrapped.inputContext)
defer close(wrapped.input)
defer close(wrapped.successes)
defer close(wrapped.errors)

go func() {
    defer close(wrapped.inputContext)
    defer close(wrapped.input)
    defer close(wrapped.successes)
    defer close(wrapped.errors)

    for {
        select {
        case msg, ok := <-producer.Successes():
            if !ok || wrapped.isClosed {
                return
            }
            endAsyncProducerTracer(wrapped, msg, nil)
            wrapped.successes <- msg

proposal

go func() {
    defer func() {
        _ = recover() // or log
        close(wrapped.inputContext)
        close(wrapped.input)
        close(wrapped.successes)
        close(wrapped.errors)
    }()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions