Skip to content

Commit 543351d

Browse files
committed
[#371] Add ConfigurationBuilder for flexible config management
1 parent 07615c0 commit 543351d

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

lib/config.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,3 @@ export declare function readConfigJson(formattedConfig: any): Partial<PinpointCo
4646
export declare function readRootConfigFile(): { [key: string]: any };
4747
export declare function getMainModulePath(requireFunction: NodeRequire): string | undefined;
4848
export declare function isContainerEnvironment(): boolean;
49-
export declare function initializeConfig(initOptions?: { [key: string]: any }): void;

lib/config.js

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -283,20 +283,6 @@ const getValue = (key, configFile) => {
283283
}
284284
}
285285

286-
const getConfig = (initOptions) => {
287-
if (!agentConfig) {
288-
init(initOptions)
289-
}
290-
return agentConfig
291-
}
292-
293-
const initializeConfig = (initOptions) => {
294-
clear()
295-
init(initOptions)
296-
}
297-
298-
const clear = () => agentConfig && (agentConfig = null)
299-
300286
//https://github.com/sindresorhus/is-docker
301287
const isContainerEnvironment = () => {
302288
return hasDockerEnv() || hasDockerCGroup() || (process.env['KUBERNETES_SERVICE_HOST'] && process.env['KUBERNETES_SERVICE_HOST'].length > 0)
@@ -462,13 +448,10 @@ const setConfig = (config) => {
462448
const clear2 = () => configInstance && (configInstance = null)
463449

464450
module.exports = {
465-
getConfig,
466-
clear,
467451
readConfigJson,
468452
readRootConfigFile,
469453
getMainModulePath,
470454
isContainerEnvironment,
471-
initializeConfig,
472455
ConfigBuilder,
473456
getConfig2,
474457
setConfig,

test/fixture.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const TransactionId = require('../lib/context/transaction-id')
88
const TraceId = require('../lib/context/trace-id')
99
const SpanId = require('../lib/context/span-id')
1010
const testConfig= require('./pinpoint-config-test')
11-
require('../lib/config').clear()
11+
require('../lib/config').clear2()
1212
const config = require('../lib/config').getConfig2(testConfig)
1313
const { namedGroupLocationFileName, namedGroupTypeMethod } = require('../lib/instrumentation/call-stack')
1414

0 commit comments

Comments
 (0)