Express Exception and URI Stats

[feelform]

• Exception Stats (https://pinpoint-apm.gitbook.io/pinpoint/documents/error_analysis)
  • /exception/handled
  • /exception/unhandled
    • Fix summary list not showing

[feelform]

@intr3p1d

After investigating the Java agent, Go agent, and Node.js agent, I found the root cause of the FrameStack not being displayed.

Root Cause

StackTraceElementWrapperBo constructor validates className and methodName with StringPrecondition.requireHasLength(), which throws IllegalArgumentException when empty:

// commons-server/.../StackTraceElementWrapperBo.java
this.className = StringPrecondition.requireHasLength(className, "className");
this.methodName = StringPrecondition.requireHasLength(methodName, "methodName");

In JavaScript, many stack frames don't have a class/type prefix:

at handler (/path/file.js:10:5)       → className = "" (empty)
at /path/file.js:10:5                 → className = "", methodName = "" (both empty)

So the Node.js agent sends empty className/methodName, and the server rejects them.

Comparison

Agent	className default	Empty handling
Java	Always present (class is required in Java)	Never empty
Go	"unknown" fallback in newFrame()	Never empty
Node.js	"" (empty string)	Server throws IllegalArgumentException

Proposed Fix (Node.js agent-side)

Field	Fallback	Reason
className	fileName (e.g. api.js)	JavaScript has no class concept; file name is the most natural identifier
methodName	<anonymous>	Consistent with V8 engine's representation of anonymous functions

Question

Is the requireHasLength validation on the server side intentionally strict, or could it be relaxed to accept empty strings? This would help us understand if the fix should be agent-side only or if the server should also handle this gracefully.