Skip to content

Conversation

@Dongnyoung
Copy link
Contributor

Hello,

Background

While testing Pinpoint in a real Spring Boot application, I observed that
ASMClassWriter logs WARN messages when optional classes are missing.

Problem

This is a normal fallback path, but logging it as WARN produces noisy logs
and may mislead users into thinking there is a problem.

Change

Lower the log level from WARN to DEBUG without altering behavior.

Verification

Reproduced by attaching the Pinpoint agent to a Spring Boot application.

스크린샷 2026-01-14 013546

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2026

CLA assistant check
All committers have signed the CLA.

@Dongnyoung Dongnyoung force-pushed the fix/asmclasswriter-loglevel branch 2 times, most recently from 1c2750b to 5ebe2ab Compare January 16, 2026 13:42
@Dongnyoung Dongnyoung force-pushed the fix/asmclasswriter-loglevel branch from 5ebe2ab to bb8e6c4 Compare January 16, 2026 13:48
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 33.18%. Comparing base (55c9a25) to head (bb8e6c4).
⚠️ Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
...p/pinpoint/profiler/instrument/ASMClassWriter.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13281      +/-   ##
============================================
- Coverage     33.21%   33.18%   -0.03%     
- Complexity    10968    10972       +4     
============================================
  Files          4062     4070       +8     
  Lines         94305    94441     +136     
  Branches       9823     9830       +7     
============================================
+ Hits          31326    31343      +17     
- Misses        60306    60424     +118     
- Partials       2673     2674       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dongnyoung Dongnyoung force-pushed the fix/asmclasswriter-loglevel branch from bb8e6c4 to cb3eddd Compare January 19, 2026 15:07
@Dongnyoung
Copy link
Contributor Author

This change only adjusts the log level (warn → debug) and does not affect runtime behavior.
The missing coverage comes from a null-check branch that is not exercised by existing tests.
Please let me know if you’d prefer a different approach or additional tests.

@jaehong-kim jaehong-kim merged commit addf07f into pinpoint-apm:master Jan 21, 2026
@jaehong-kim
Copy link
Contributor

@Dongnyoung
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants