Skip to content

Conversation

@donghun-cho
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for OpenTelemetry trace IDs in the TraceIndexTable by introducing a polymorphic encoding/decoding mechanism that handles both Pinpoint and OpenTelemetry server trace IDs.

Changes:

  • Introduced type-based encoding/decoding for ServerTraceId to support both PinpointServerTraceId and OtelServerTraceId
  • Renamed field from transactionId to serverTraceId in TraceIndexValue.Meta record for better clarity
  • Added comprehensive tests for both Pinpoint and OpenTelemetry trace ID encoding/decoding

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
commons-server/src/main/java/com/navercorp/pinpoint/common/server/scatter/TraceIndexValue.java Added trace type constants and polymorphic encoding/decoding logic; renamed field from transactionId to serverTraceId
commons-server/src/main/java/com/navercorp/pinpoint/common/server/trace/OtelServerTraceId.java Added new factory method to create OtelServerTraceId from Buffer
web/src/main/java/com/navercorp/pinpoint/web/scatter/vo/DotMetaData.java Updated to use serverTraceId() accessor method instead of transactionId()
commons-server/src/test/java/com/navercorp/pinpoint/common/server/scatter/TraceIndexValueTest.java New test file with comprehensive tests for Index, Meta (both Pinpoint and Otel), and MetaRpc encoding/decoding

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.24%. Comparing base (2c2ffc7) to head (9798e38).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...inpoint/common/server/scatter/TraceIndexValue.java 77.77% 2 Missing and 2 partials ⚠️
...navercorp/pinpoint/web/scatter/vo/DotMetaData.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13305      +/-   ##
============================================
+ Coverage     33.18%   33.24%   +0.05%     
- Complexity    10973    10979       +6     
============================================
  Files          4070     4070              
  Lines         94432    94448      +16     
  Branches       9830     9835       +5     
============================================
+ Hits          31338    31398      +60     
+ Misses        60420    60374      -46     
- Partials       2674     2676       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@donghun-cho donghun-cho merged commit 40dbb76 into pinpoint-apm:master Jan 19, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant