[#noissue] Introduce SpanHeader enum for the trace qualifier type byte#14049
Open
emeroad wants to merge 1 commit into
Open
[#noissue] Introduce SpanHeader enum for the trace qualifier type byte#14049emeroad wants to merge 1 commit into
emeroad wants to merge 1 commit into
Conversation
- SpanHeader enum owns the code <-> span/chunk/source-type mapping; decoders resolve headers via SpanHeader.of(byte) - Add serviceUid-bearing *_UID variants so the qualifier can carry a serviceUid - SpanHeaderFactory owns the write-path variant selection and the collector.span.serviceuid.enabled policy
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14049 +/- ##
============================================
+ Coverage 34.64% 34.67% +0.02%
- Complexity 12300 12325 +25
============================================
Files 4203 4204 +1
Lines 99848 99874 +26
Branches 10695 10703 +8
============================================
+ Hits 34594 34630 +36
+ Misses 62313 62297 -16
- Partials 2941 2947 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



decoders resolve headers via SpanHeader.of(byte)
a serviceUid
collector.span.serviceuid.enabled policy