Skip to content

[#noissue] Introduce SpanHeader enum for the trace qualifier type byte#14049

Open
emeroad wants to merge 1 commit into
pinpoint-apm:masterfrom
emeroad:span-header-enum
Open

[#noissue] Introduce SpanHeader enum for the trace qualifier type byte#14049
emeroad wants to merge 1 commit into
pinpoint-apm:masterfrom
emeroad:span-header-enum

Conversation

@emeroad

@emeroad emeroad commented Jul 22, 2026

Copy link
Copy Markdown
Member
  • SpanHeader enum owns the code <-> span/chunk/source-type mapping;
    decoders resolve headers via SpanHeader.of(byte)
  • Add serviceUid-bearing *_UID variants so the qualifier can carry
    a serviceUid
  • SpanHeaderFactory owns the write-path variant selection and the
    collector.span.serviceuid.enabled policy

- SpanHeader enum owns the code <-> span/chunk/source-type mapping;
  decoders resolve headers via SpanHeader.of(byte)
- Add serviceUid-bearing *_UID variants so the qualifier can carry
  a serviceUid
- SpanHeaderFactory owns the write-path variant selection and the
  collector.span.serviceuid.enabled policy
@emeroad emeroad added this to the 4.0.0 milestone Jul 22, 2026
@emeroad
emeroad requested a review from jaehong-kim July 22, 2026 06:53
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.67%. Comparing base (6d39146) to head (1e8c85c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...er/trace/v2/config/SpanSerializeConfiguration.java 0.00% 2 Missing ⚠️
...rver/bo/serializer/trace/v2/SpanHeaderFactory.java 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14049      +/-   ##
============================================
+ Coverage     34.64%   34.67%   +0.02%     
- Complexity    12300    12325      +25     
============================================
  Files          4203     4204       +1     
  Lines         99848    99874      +26     
  Branches      10695    10703       +8     
============================================
+ Hits          34594    34630      +36     
+ Misses        62313    62297      -16     
- Partials       2941     2947       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant