[#14039] Remove obsolete query parameters from serviceMap request#14056
Merged
Conversation
… request Backend PR pinpoint-apm#14040 dropped SearchOption (callerRange/calleeRange/ bidirectional/wasOnly) and keepServiceNames from GET /serviceMap; the service map is queried per service unit with a fixed search depth. Stop sending these now-ignored parameters from the FE.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14056 +/- ##
============================================
- Coverage 34.67% 34.67% -0.01%
+ Complexity 12320 12319 -1
============================================
Files 4204 4204
Lines 99910 99910
Branches 10701 10701
============================================
- Hits 34644 34643 -1
Misses 62323 62323
- Partials 2943 2944 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /serviceMap; the service map is now queried per service unit with a fixed search depth.GetServiceMap.Parameters,useGetServiceMap,ServiceMapFetcher).Test plan
/serviceMaprequest URL no longer includes callerRange/calleeRange/bidirectional/wasOnly/keepServiceNames