Merge pull request #16 from jmah/jmah/thread-safety-fix

garrettmoon · garrettmoon · commit bbf05dec240c · 2015-08-01T14:06:28.000-07:00
Fix concurrency issue: Only alter completions dictionary while locked
diff --git a/Pod/Classes/PINURLSessionManager.m b/Pod/Classes/PINURLSessionManager.m
@@ -72,10 +72,10 @@ - (void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task didComp
     [self.delegate didCompleteTask:task withError:error];
     [self lock];
         void (^completionHandler)(NSURLResponse *, NSError *) = self.completions[@(task.taskIdentifier)];
+        [self.completions removeObjectForKey:@(task.taskIdentifier)];
     [self unlock];
     if (completionHandler) {
         completionHandler(task.response, error);
-        [self.completions removeObjectForKey:@(task.taskIdentifier)];
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -72,10 +72,10 @@ - (void)URLSession:(NSURLSession )session task:(NSURLSessionTask )task didComp`
`72`	`72`	`[self.delegate didCompleteTask:task withError:error];`
`73`	`73`	`[self lock];`
`74`	`74`	`void (^completionHandler)(NSURLResponse , NSError ) = self.completions[@(task.taskIdentifier)];`
	`75`	`+ [self.completions removeObjectForKey:@(task.taskIdentifier)];`
`75`	`76`	`[self unlock];`
`76`	`77`	`if (completionHandler) {`
`77`	`78`	`completionHandler(task.response, error);`
`78`		`- [self.completions removeObjectForKey:@(task.taskIdentifier)];`
`79`	`79`	`}`
`80`	`80`	`}`
`81`	`81`