-
Notifications
You must be signed in to change notification settings - Fork 24
Expand file tree
/
Copy pathjson_logger_test.go
More file actions
383 lines (293 loc) · 11.8 KB
/
json_logger_test.go
File metadata and controls
383 lines (293 loc) · 11.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
// SPDX-FileCopyrightText: 2026 The Pion community <https://pion.ly>
// SPDX-License-Identifier: MIT
package logging
import (
"bytes"
"encoding/json"
"fmt"
"io"
"log/slog"
"os"
"strings"
"testing"
"github.com/stretchr/testify/assert"
)
func TestJSONLoggerLevels(t *testing.T) {
logger := newJSONLeveledLoggerForScope("test", LogLevelTrace, os.Stderr)
var outBuf bytes.Buffer
logger.WithOutput(&outBuf)
// Test Info level
infoMsg := "this is an info message"
logger.Info(infoMsg)
output := outBuf.String()
assert.True(t, strings.Contains(output, infoMsg), "Expected to find %q in %q", infoMsg, output)
assert.True(t, strings.Contains(output, `"level":"INFO"`), "Expected JSON to contain INFO level")
assert.True(t, strings.Contains(output, `"scope":"test"`), "Expected JSON to contain scope")
// Test Debug level
outBuf.Reset()
debugMsg := "this is a debug message"
logger.Debug(debugMsg)
output = outBuf.String()
assert.True(t, strings.Contains(output, debugMsg), "Expected to find %q in %q", debugMsg, output)
assert.True(t, strings.Contains(output, `"level":"DEBUG"`), "Expected JSON to contain DEBUG level")
// Test Warn level
outBuf.Reset()
warnMsg := "this is a warning message"
logger.Warn(warnMsg)
output = outBuf.String()
assert.True(t, strings.Contains(output, warnMsg), "Expected to find %q in %q", warnMsg, output)
assert.True(t, strings.Contains(output, `"level":"WARN"`), "Expected JSON to contain WARN level")
// Test Error level
outBuf.Reset()
errMsg := "this is an error message"
logger.Error(errMsg)
output = outBuf.String()
assert.True(t, strings.Contains(output, errMsg), "Expected to find %q in %q", errMsg, output)
assert.True(t, strings.Contains(output, `"level":"ERROR"`), "Expected JSON to contain ERROR level")
// Test Trace level
outBuf.Reset()
traceMsg := "this is a trace message"
logger.Trace(traceMsg)
output = outBuf.String()
assert.True(t, strings.Contains(output, traceMsg), "Expected to find %q in %q", traceMsg, output)
}
func TestJSONLoggerFormatting(t *testing.T) {
logger := newJSONLeveledLoggerForScope("test", LogLevelTrace, os.Stderr)
var outBuf bytes.Buffer
logger.WithOutput(&outBuf)
// Test formatted messages
formatMsg := "formatted message with %s"
arg := "argument"
logger.Infof(formatMsg, arg)
output := outBuf.String()
expectedMsg := "formatted message with argument"
assert.True(t, strings.Contains(output, expectedMsg), "Expected to find %q in %q", expectedMsg, output)
}
func TestJSONLoggerLevelFiltering(t *testing.T) {
logger := newJSONLeveledLoggerForScope("test", LogLevelTrace, os.Stderr)
var outBuf bytes.Buffer
logger.WithOutput(&outBuf)
// Set level to WARN, so DEBUG and INFO should be filtered
logger.SetLevel(LogLevelWarn)
// These should not be logged
logger.Debug("debug message")
logger.Info("info message")
assert.Equal(t, 0, outBuf.Len(), "Debug and Info messages should not be logged at WARN level")
// These should be logged
logger.Warn("warn message")
logger.Error("error message")
output := outBuf.String()
assert.True(t, strings.Contains(output, "warn message"), "Warn message should be logged")
assert.True(t, strings.Contains(output, "error message"), "Error message should be logged")
}
func TestJSONLoggerFactory(t *testing.T) {
factory := jsonLoggerFactory{
writer: os.Stderr,
defaultLogLevel: LogLevelWarn,
scopeLevels: map[string]LogLevel{
"foo": LogLevelDebug,
},
}
logger := factory.NewLogger("baz")
bazLogger, ok := logger.(*jsonLeveledLogger)
assert.True(t, ok, "Invalid logger type")
// Test that baz logger respects WARN level
var outBuf bytes.Buffer
bazLogger.WithOutput(&outBuf)
bazLogger.Debug("debug message")
assert.Equal(t, 0, outBuf.Len(), "Debug message should not be logged at WARN level")
logger = factory.NewLogger("foo")
fooLogger, ok := logger.(*jsonLeveledLogger)
assert.True(t, ok, "Invalid logger type")
// Test that foo logger respects DEBUG level
outBuf.Reset()
fooLogger.WithOutput(&outBuf)
fooLogger.Debug("debug message")
output := outBuf.String()
assert.True(t, strings.Contains(output, "debug message"), "Debug message should be logged at DEBUG level")
}
func TestNewJSONLoggerFactoryReturnsPrivateType(t *testing.T) {
factory := NewJSONLoggerFactory()
assert.Equal(t, "*logging.jsonLoggerFactory", fmt.Sprintf("%T", factory))
}
func TestNewJSONLoggerFactory(t *testing.T) {
factory := NewJSONLoggerFactory()
disabled := factory.NewLogger("DISABLE")
errorLevel := factory.NewLogger("ERROR")
warnLevel := factory.NewLogger("WARN")
infoLevel := factory.NewLogger("INFO")
debugLevel := factory.NewLogger("DEBUG")
traceLevel := factory.NewLogger("TRACE")
disabledLogger, ok := disabled.(*jsonLeveledLogger)
assert.True(t, ok, "Missing disabled logger")
errorLogger, ok := errorLevel.(*jsonLeveledLogger)
assert.True(t, ok, "Missing error logger")
_, ok = warnLevel.(*jsonLeveledLogger)
assert.True(t, ok, "Missing warn logger")
_, ok = infoLevel.(*jsonLeveledLogger)
assert.True(t, ok, "Missing info logger")
_, ok = debugLevel.(*jsonLeveledLogger)
assert.True(t, ok, "Missing debug logger")
_, ok = traceLevel.(*jsonLeveledLogger)
assert.True(t, ok, "Missing trace logger")
// Test that all loggers are properly configured
var outBuf bytes.Buffer
disabledLogger.WithOutput(&outBuf)
disabledLogger.Info("test message")
assert.Equal(t, 0, outBuf.Len(), "Disabled logger should not log anything")
outBuf.Reset()
errorLogger.WithOutput(&outBuf)
errorLogger.Error("error message")
output := outBuf.String()
assert.True(t, strings.Contains(output, "error message"), "Error logger should log error messages")
}
func TestNewJSONLoggerFactoryOptions(t *testing.T) {
var outBuf bytes.Buffer
factory := unwrapJSONFactory(t, NewJSONLoggerFactory(
WithJSONWriter(&outBuf),
WithJSONDefaultLevel(LogLevelDebug),
WithJSONScopeLevels(map[string]LogLevel{"CustomScope": LogLevelTrace}),
))
assert.Equal(t, LogLevelDebug, factory.defaultLogLevel)
assert.Equal(t, LogLevelTrace, factory.scopeLevels["customscope"])
logger := factory.NewLogger("customscope")
logger.Debug("configured logger output")
assert.Contains(t, outBuf.String(), "configured logger output")
}
func TestJSONLoggerFactorySupportsWithOutputInterface(t *testing.T) {
factory := NewJSONLoggerFactory()
logger := factory.NewLogger("interface-scope")
withOutput, ok := logger.(interface {
WithOutput(io.Writer) LeveledLogger
})
assert.True(t, ok, "Logger should allow WithOutput without concrete type")
var outBuf bytes.Buffer
withOutput.WithOutput(&outBuf)
logger.Error("interface error")
assert.Contains(t, outBuf.String(), "interface error")
}
func TestJSONLoggerTraceOutput(t *testing.T) {
logger := newJSONLeveledLoggerForScope("trace-scope", LogLevelTrace, os.Stderr)
var outBuf bytes.Buffer
logger.WithOutput(&outBuf)
logger.Trace("test message")
output := outBuf.String()
// Verify it's valid JSON
var jsonData map[string]any
err := json.Unmarshal([]byte(output), &jsonData)
assert.NoError(t, err, "Output should be valid JSON")
// Verify required fields
assert.Contains(t, jsonData, "time", "JSON should contain time field")
assert.Contains(t, jsonData, "level", "JSON should contain level field")
assert.Contains(t, jsonData, "msg", "JSON should contain msg field")
assert.Contains(t, jsonData, "scope", "JSON should contain scope field")
// Verify values
assert.Equal(t, "TRACE", jsonData["level"], "Level should be TRACE")
assert.Equal(t, "test message", jsonData["msg"], "Message should match")
assert.Equal(t, "trace-scope", jsonData["scope"], "Scope should match")
}
func TestJSONLoggerStructuredOutput(t *testing.T) {
logger := newJSONLeveledLoggerForScope("test-scope", LogLevelInfo, os.Stderr)
var outBuf bytes.Buffer
logger.WithOutput(&outBuf)
logger.Info("test message")
output := outBuf.String()
// Verify it's valid JSON
var jsonData map[string]any
err := json.Unmarshal([]byte(output), &jsonData)
assert.NoError(t, err, "Output should be valid JSON")
// Verify required fields
assert.Contains(t, jsonData, "time", "JSON should contain time field")
assert.Contains(t, jsonData, "level", "JSON should contain level field")
assert.Contains(t, jsonData, "msg", "JSON should contain msg field")
assert.Contains(t, jsonData, "scope", "JSON should contain scope field")
// Verify values
assert.Equal(t, "INFO", jsonData["level"], "Level should be INFO")
assert.Equal(t, "test message", jsonData["msg"], "Message should match")
assert.Equal(t, "test-scope", jsonData["scope"], "Scope should match")
}
func TestJSONLeveledLogger_logf_IncludesAdditionalArgs(t *testing.T) {
factory := newJSONLoggerFactory()
factory.writer = os.Stderr
factory.defaultLogLevel = LogLevelTrace
l := factory.NewLogger("test-scope")
jl, ok := l.(*jsonLeveledLogger)
assert.True(t, ok, "Invalid logger type")
var outBuf bytes.Buffer
jl.WithOutput(&outBuf)
args := []any{
"method", "GET",
"path", "/users",
"duration_ms", 15,
"ok", true,
}
jl.logf(slog.LevelInfo, "Processing request", args...)
raw := strings.TrimSpace(outBuf.String())
var jsonData map[string]any
err := json.Unmarshal([]byte(raw), &jsonData)
assert.NoError(t, err, "Output should be valid JSON")
// base fields
assert.Equal(t, "Processing request", jsonData["msg"])
assert.Equal(t, "INFO", jsonData["level"])
assert.Equal(t, "test-scope", jsonData["scope"])
// additional args should appear as structured fields
assert.Equal(t, "GET", jsonData["method"])
assert.Equal(t, "/users", jsonData["path"])
assert.EqualValues(t, 15, jsonData["duration_ms"]) // json.Unmarshal numbers -> float64
assert.Equal(t, true, jsonData["ok"])
}
func clearLogEnv(t *testing.T) {
t.Helper()
for _, name := range []string{"DISABLE", "ERROR", "WARN", "INFO", "DEBUG", "TRACE"} {
t.Setenv("PION_LOG_"+name, "")
t.Setenv("PIONS_LOG_"+name, "")
}
}
func unwrapJSONFactory(t *testing.T, factory LoggerFactory) *jsonLoggerFactory {
t.Helper()
jf, ok := factory.(*jsonLoggerFactory)
assert.True(t, ok, "Factory should be jsonLoggerFactory")
return jf
}
func TestNewJSONLoggerFactory_AllSetsDefaultToMaxLevel(t *testing.T) {
clearLogEnv(t)
t.Setenv("PION_LOG_INFO", "All")
t.Setenv("PION_LOG_DEBUG", "ALL")
t.Setenv("PION_LOG_TRACE", "all")
factory := unwrapJSONFactory(t, NewJSONLoggerFactory())
assert.Equal(t, LogLevelTrace, factory.defaultLogLevel)
assert.Equal(t, 0, len(factory.scopeLevels))
}
func TestNewJSONLoggerFactory_AllDoesNotLowerDefaultLevel(t *testing.T) {
clearLogEnv(t)
t.Setenv("PION_LOG_DISABLE", "all")
factory := unwrapJSONFactory(t, NewJSONLoggerFactory())
assert.Equal(t, LogLevelError, factory.defaultLogLevel)
}
func TestNewJSONLoggerFactory_ScopesAreSplitAndLowercased(t *testing.T) {
clearLogEnv(t)
t.Setenv("PION_LOG_DEBUG", "Foo,BAR")
factory := unwrapJSONFactory(t, NewJSONLoggerFactory())
assert.Equal(t, LogLevelError, factory.defaultLogLevel)
assert.Equal(t, LogLevelDebug, factory.scopeLevels["foo"])
assert.Equal(t, LogLevelDebug, factory.scopeLevels["bar"])
}
func TestNewJSONLoggerFactory_AllAndScopedInteract(t *testing.T) {
clearLogEnv(t)
t.Setenv("PION_LOG_WARN", "all")
t.Setenv("PION_LOG_DEBUG", "foo")
factory := unwrapJSONFactory(t, NewJSONLoggerFactory())
assert.Equal(t, LogLevelWarn, factory.defaultLogLevel)
assert.Equal(t, LogLevelDebug, factory.scopeLevels["foo"])
foo := factory.NewLogger("foo").(*jsonLeveledLogger) //nolint:forcetypeassert
bar := factory.NewLogger("bar").(*jsonLeveledLogger) //nolint:forcetypeassert
assert.Equal(t, LogLevelDebug, foo.level.Get(), "scope override should win")
assert.Equal(t, LogLevelWarn, bar.level.Get(), "default should apply when no scope override")
}
func TestNewJSONLoggerFactory_Fallback(t *testing.T) {
clearLogEnv(t)
t.Setenv("PION_LOG_INFO", "")
t.Setenv("PIONS_LOG_INFO", "all")
factory := unwrapJSONFactory(t, NewJSONLoggerFactory())
assert.Equal(t, LogLevelInfo, factory.defaultLogLevel)
}