Skip to content

Update association.go to RFC 9260 #409

Description

@philipch07

The first issue I found with this is regarding https://github.com/pion/sctp/blame/012d2b44dbc178427e0c25b8f17a527f04e2032c/association.go#L1797 which refers to RFC 4960 section 7.2.1 "Slow Start". The line is:

a.setCWND(a.CWND() + min32(uint32(totalBytesAcked), a.CWND()))

but according to the RFC it should be:

a.setCWND(a.CWND() + min32(uint32(totalBytesAcked), a.MTU()))

The problem is, testing the impact of this is really difficult since it's so small. The change I would like instead is to just update association.go to abide by rfc 9260 as it uses a different approach instead.

The only concern I have at the moment is that association.go is really big so it will probably take a while.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels
    No fields configured for Feature.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions