Deprecate XorBytes

Now that we no longer support Go 1.19, we might as well deprecate XorBytes and use the stdlib version instead.
pion · Sep 20, 2024 · e62d789 · e62d789
1 parent e8ac9ae
commit e62d789
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 256 deletions.
diff --git a/go.mod b/go.mod
@@ -7,11 +7,11 @@ require (
 	github.com/stretchr/testify v1.9.0
 	github.com/wlynxg/anet v0.0.4
 	golang.org/x/net v0.28.0
-	golang.org/x/sys v0.24.0
 )
 
 require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
+	golang.org/x/sys v0.24.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
diff --git a/utils/xor/xor_generic.go → utils/xor/xor.go b/utils/xor/xor_generic.go → utils/xor/xor.go
@@ -3,8 +3,6 @@
 // SPDX-FileCopyrightText: 2024 The Pion community <https://pion.ly>
 // SPDX-License-Identifier: MIT
 
-//go:build go1.20 && !arm && !gccgo
-
 // Package xor provides the XorBytes function.
 package xor
 
@@ -14,6 +12,8 @@ import (
 
 // XorBytes calls [crypto/suble.XORBytes].
 //
+// Deprecated: please call [crypto/subtle.XORBytes] instead.
+//
 //revive:disable-next-line
 func XorBytes(dst, a, b []byte) int {
 	return subtle.XORBytes(dst, a, b)

diff --git a/utils/xor/xor_arm.go b/utils/xor/xor_arm.go
diff --git a/utils/xor/xor_arm.s b/utils/xor/xor_arm.s
diff --git a/utils/xor/xor_old.go b/utils/xor/xor_old.go