Prove data race

Author: JoeTurki

rtpreceiver_test.go

@@ -10,6 +10,8 @@ import (
 	"context"
 	"io"
 	"math"
+	"sync"
+	"sync/atomic"
 	"testing"
 	"time"
 
@@ -137,6 +139,74 @@ func TestRTPReceiver_ClosedReceiveForRIDAndRTX(t *testing.T) {
 	}
 }
 
+func TestRTPReceiver_readRTX_ChannelAccessSafe(t *testing.T) {
+	receiver := &RTPReceiver{
+		kind:       RTPCodecTypeVideo,
+		received:   make(chan any),
+		closedChan: make(chan any),
+		rtxPool: sync.Pool{New: func() any {
+			return make([]byte, 1200)
+		}},
+	}
+
+	receiver.configureReceive(RTPReceiveParameters{
+		Encodings: []RTPDecodingParameters{
+			{
+				RTPCodingParameters: RTPCodingParameters{
+					RID:  "rid",
+					SSRC: 1111,
+					RTX: RTPRtxParameters{
+						SSRC: 2222,
+					},
+				},
+			},
+		},
+	})
+
+	params := RTPParameters{
+		Codecs: []RTPCodecParameters{
+			{
+				RTPCodecCapability: RTPCodecCapability{MimeType: MimeTypeVP8},
+				PayloadType:        96,
+			},
+		},
+	}
+	ridStreamInfo := &interceptor.StreamInfo{SSRC: 1111}
+	track, err := receiver.receiveForRid("rid", params, ridStreamInfo, nil, nil, nil, nil, nil)
+	require.NoError(t, err)
+
+	close(receiver.received)
+
+	raw := []byte{0x80, 0x60, 0x12, 0x34, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x02, 0xAA, 0xBB}
+	var returnedOnce atomic.Bool
+	rtpInterceptor := interceptor.RTPReaderFunc(func(b []byte, a interceptor.Attributes) (int, interceptor.Attributes, error) {
+		if returnedOnce.Load() {
+			return 0, a, io.EOF
+		}
+		returnedOnce.Store(true)
+
+		n := copy(b, raw)
+		return n, a, nil
+	})
+
+	repairStreamInfo := &interceptor.StreamInfo{SSRC: 2222}
+	require.NoError(t, receiver.receiveForRtxInternal(SSRC(2222), "", repairStreamInfo, nil, rtpInterceptor, nil, nil))
+
+	deadline := time.After(time.Second)
+	for {
+		if pkt := receiver.readRTX(track); pkt != nil {
+			return
+		}
+
+		select {
+		case <-deadline:
+			t.Fatal("expected RTX packet")
+		default:
+			time.Sleep(5 * time.Millisecond)
+		}
+	}
+}
+
 // TestRTPReceiver_CollectStats_Mapping validates that collectStats maps
 // interceptor/pkg/stats values into InboundRTPStreamStats.
 func TestRTPReceiver_CollectStats_Mapping(t *testing.T) {