Skip to content

handleIncomingSSRC doesn't handle multiple padding packets #3330

@jech

Description

@jech

Hi Sean,

I'm trying to understand your changes to handleIncomingSSRC, and I'm struggling to understand this function.

  1. The code that skips padding packets (if mid == "" || (rid == "" && rsid == "")) is only called once; what happens if there are multiple padding packets at the beginning of the stream?
  2. After we read the second packet, we immediately search for a maching transceiver without checking that we have either rid or rsid; is it possible at this point that we have mid but neither rid nor rsid? What will happen in that case?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions