Sparkles in terrain when viewing night side, also strangely illuminated mountains at night

[fluffyfreak]

Observed behaviour

As reported here

Expected behaviour

Terrain shouldn't sparkle, mountains like Olympus Mons should not be illuminated by the sun when on the dark side of a planet.

Steps to reproduce

Load the attached savegame, issues should be immediatly visible at lowest time step

My pioneer version (and OS):
Latest source code, Windows 11

My output.txt (required) and game save (optional, but recommended)
output.txt

olympusmons.txt

[sturnclaw]

Going off of prior (successful) attempts to fix visual sparkling, the bright pixels are caused by an out-of-range/unnormalized value during the lighting calculation. Not sure about incorrect terrain lighting here, but the whole thing needs to be replaced with a new lighting calc that integrates the new scattering algorithm regardless. I wouldn't spend too much time chasing this down.