[PipeCD-DataStore] fix: nil pointer dereference in UpdatePluginMetadata (#6611)

armistcxy · web-flow · commit 6b8204fbc3ba · 2026-03-23T22:03:53.000+09:00
Signed-off-by: Hoang Ngo &lt;adlehoang118@gmail.com&gt;
diff --git a/pkg/datastore/deploymentstore.go b/pkg/datastore/deploymentstore.go
@@ -264,6 +264,9 @@ func (s *deploymentStore) UpdatePluginMetadata(ctx context.Context, id string, p
 		if d.MetadataV2.Plugins == nil {
 			d.MetadataV2.Plugins = make(map[string]*model.DeploymentMetadata_KeyValues)
 		}
+		if d.MetadataV2.Plugins[pluginName] == nil {
+			d.MetadataV2.Plugins[pluginName] = &model.DeploymentMetadata_KeyValues{}
+		}
 		d.MetadataV2.Plugins[pluginName] = &model.DeploymentMetadata_KeyValues{
 			KeyValues: mergeMetadata(d.MetadataV2.Plugins[pluginName].KeyValues, metadata),
 		}

Original file line number	Diff line number	Diff line change
`@@ -264,6 +264,9 @@ func (s *deploymentStore) UpdatePluginMetadata(ctx context.Context, id string, p`
`264`	`264`	`if d.MetadataV2.Plugins == nil {`
`265`	`265`	`d.MetadataV2.Plugins = make(map[string]*model.DeploymentMetadata_KeyValues)`
`266`	`266`	`}`
	`267`	`+ if d.MetadataV2.Plugins[pluginName] == nil {`
	`268`	`+ d.MetadataV2.Plugins[pluginName] = &model.DeploymentMetadata_KeyValues{}`
	`269`	`+ }`
`267`	`270`	`d.MetadataV2.Plugins[pluginName] = &model.DeploymentMetadata_KeyValues{`
`268`	`271`	`KeyValues: mergeMetadata(d.MetadataV2.Plugins[pluginName].KeyValues, metadata),`
`269`	`272`	`}`