-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
From Codex review:
- High: unresolved finished(...) function call times out after task completion
tmp.goog.log:92552, tmp.goog.log:92556, tmp.goog.log:92572, tmp.goog.log:92578, tmp.goog.log:92753
Impact: task completes, but the finished function call never resolves; this leaves a timeout handler alive and produces a
20s timeout warning.
Fix: on task cancel/finish paths, force-resolve in-flight function calls (especially finished) and emit a
FunctionCallResultFrame before pipeline teardown. - High: intermittent silent turns after corporation_info (user must nudge with “What?”/“Check?”/“Hello?”)
Examples: tmp.goog.log:35506, tmp.goog.log:35942, tmp.goog.log:38742, tmp.goog.log:39498; tmp.goog.log:40499,
tmp.goog.log:40904, tmp.goog.log:41022, tmp.goog.log:41277; tmp.goog.log:21498, tmp.goog.log:21776
Impact: direct user questions can produce no spoken answer on first turn.
Fix: add a voice-agent zero-token fallback: if post-tool inference returns completion tokens: 0 and no tool calls, auto-
reprompt/retry once (or synthesize a safe fallback response) instead of waiting for user follow-up. - Medium: task-scoped course.plot is ignored by relay/UI, but still emitted via task output stream
Ignored correctly: tmp.goog.log:77701, tmp.goog.log:77703, tmp.goog.log:77704
Still emitted in task output: tmp.goog.log:77705, tmp.goog.log:83850
Impact: if client map logic listens to task output events, it can still draw unintended route lines.
Fix: suppress task-scoped course.plot in task output payloads, or enforce client-side filtering by task_id/voice-request
correlation before drawing. - Medium: duplicate error emission for same failed trade request
Examples for same request_id: tmp.goog.log:23407 and tmp.goog.log:23607; tmp.goog.log:24724 and tmp.goog.log:24922;
tmp.goog.log:39286 and tmp.goog.log:39485
Impact: duplicate [EVENT] error/[ERROR] noise can confuse task reasoning and UI/log consumers.
Fix: dedupe by request_id (prefer authoritative server event; suppress synthesized duplicate if real error event
arrives). - Medium: recurring dangling task warnings
tmp.goog.log:2992, tmp.goog.log:13267, tmp.goog.log:38733, tmp.goog.log:40336, tmp.goog.log:71869, tmp.goog.log:75886,
tmp.goog.log:79801, tmp.goog.log:95441
Impact: indicates cleanup gaps; one instance is directly tied to the unresolved finished timeout handler.
Fix: tighten pipeline shutdown ordering and ensure task manager drains/cancels runner + processor tasks
deterministically. - Low: context compression sees duplicate system prompts
tmp.goog.log:44280
Impact: potential prompt bloat/instruction conflicts.
Fix: enforce single canonical system message before compression.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels